CDRIVER-4006 remove deprecated public API with oppressive language (#1908)

* remove `mongoc_server_description_ismaster`

* remove `MONGOC_QUERY_SLAVE_OK`

* remove `MONGOC_URI_SLAVEOK`

Author: kevinAlbs

NEWS

@@ -12,6 +12,9 @@ Unreleased (2.0.0)
 
 * The `bson_md5_t` struct and associated API is removed.
 * The client side matching feature, `mongoc_matcher_t` and related functions are removed.
+* `mongoc_server_description_ismaster` is removed. Use the equivalent `mongoc_server_description_hello` instead.
+* `MONGOC_QUERY_SLAVE_OK` is removed. Use the equivalent `MONGOC_QUERY_SECONDARY_OK` instead.
+* `MONGOC_URI_SLAVEOK` is removed. It was unused.
 
 ### Forwarding headers (`#include <bson.h>` and `#include <mongoc.h>`)
 

src/libmongoc/doc/mongoc_server_description_ismaster.rst

@@ -36,7 +36,6 @@ Applications receive a temporary reference to a ``mongoc_server_description_t``
     mongoc_server_description_hello_response
     mongoc_server_description_host
     mongoc_server_description_id
-    mongoc_server_description_ismaster
     mongoc_server_description_last_update_time
     mongoc_server_description_new_copy
     mongoc_server_description_round_trip_time

src/libmongoc/doc/mongoc_server_description_t.rst

@@ -95,7 +95,6 @@ typedef enum {
 typedef enum {
    MONGOC_QUERY_NONE = 0,
    MONGOC_QUERY_TAILABLE_CURSOR = 1 << 1,
-   MONGOC_QUERY_SLAVE_OK = 1 << 2,
    MONGOC_QUERY_SECONDARY_OK = 1 << 2,
    MONGOC_QUERY_OPLOG_REPLAY = 1 << 3,
    MONGOC_QUERY_NO_CURSOR_TIMEOUT = 1 << 4,

src/libmongoc/src/mongoc/mongoc-flags.h

@@ -389,25 +389,6 @@ mongoc_server_description_hello_response (const mongoc_server_description_t *des
    return &description->last_hello_response;
 }
 
-/*
- *--------------------------------------------------------------------------
- *
- * mongoc_server_description_ismaster --
- *
- *      Return this server's most recent "hello" command response.
- *
- * Returns:
- *      A reference to a BSON document, owned by the server description.
- *
- *--------------------------------------------------------------------------
- */
-
-const bson_t *
-mongoc_server_description_ismaster (const mongoc_server_description_t *description)
-{
-   return mongoc_server_description_hello_response (description);
-}
-
 /*
  *--------------------------------------------------------------------------
  *

src/libmongoc/src/mongoc/mongoc-server-description.c

@@ -53,9 +53,6 @@ mongoc_server_description_type (const mongoc_server_description_t *description);
 MONGOC_EXPORT (const bson_t *)
 mongoc_server_description_hello_response (const mongoc_server_description_t *description);
 
-BSON_DEPRECATED_FOR (mongoc_server_description_hello_response)
-MONGOC_EXPORT (const bson_t *) mongoc_server_description_ismaster (const mongoc_server_description_t *description);
-
 MONGOC_EXPORT (int32_t)
 mongoc_server_description_compressor_id (const mongoc_server_description_t *description);
 

src/libmongoc/src/mongoc/mongoc-server-description.h

@@ -60,7 +60,6 @@
 #define MONGOC_URI_SERVERMONITORINGMODE "servermonitoringmode"
 #define MONGOC_URI_SERVERSELECTIONTIMEOUTMS "serverselectiontimeoutms"
 #define MONGOC_URI_SERVERSELECTIONTRYONCE "serverselectiontryonce"
-#define MONGOC_URI_SLAVEOK "slaveok"
 #define MONGOC_URI_SOCKETCHECKINTERVALMS "socketcheckintervalms"
 #define MONGOC_URI_SOCKETTIMEOUTMS "sockettimeoutms"
 #define MONGOC_URI_SRVSERVICENAME "srvservicename"