changes assignment to equality check #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Mar 9, 2021
| @@ -20,7 +20,7 @@ | |||
| typedef struct _mongoc_timeout_t { | |||
| bool is_set; | |||
| int64_t timeout_ms; | |||
| } mongoc_timeout_t; | |||
| }; | |||
There was a problem hiding this comment.
This change produces a build failure for me on MacOS:
[ 43%] Building C object src/libmongoc/CMakeFiles/mongoc_shared.dir/src/mongoc/mongoc-topology.c.o
/Users/alcaeus/Code/mongodb/mongo-c-driver/src/libmongoc/src/mongoc/mongoc-timeout.c:20:1: error: typedef requires a name [-Werror,-Wmissing-declarations]
typedef struct _mongoc_timeout_t {
^~~~~~~
1 error generated.
make[2]: *** [src/libmongoc/CMakeFiles/mongoc_shared.dir/src/mongoc/mongoc-timeout.c.o] Error 1
There was a problem hiding this comment.
Submitted a PR for this here: #746. Can you confirm it works locally?
There was a problem hiding this comment.
Approved the PR after confirming it works. Thanks for the quick turnaround!
chardan
pushed a commit
to chardan/mongo-c-driver
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes redefinition of mongoc_timeout_t.