Skip to content

CDRIVER-3931 Check for null document in bson parser parse #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

CDRIVER-3931 Check for null document in bson parser parse #760

merged 1 commit into from
Mar 17, 2021

Conversation

benjirewis
Copy link
Contributor

CDRIVER-3931

The bson test util bson_parser_parse can run BSON_FOREACH on a NULL document causing an error in BSON_ASSERT. Adds a check to verify the document isn't NULL.

@benjirewis benjirewis requested a review from bazile-clyde March 17, 2021 19:22
@benjirewis benjirewis mentioned this pull request Mar 17, 2021
Merged
bazile-clyde
bazile-clyde approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@bazile-clyde bazile-clyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for creating the ticket for this.

@benjirewis benjirewis merged commit 505bfca into mongodb:master Mar 17, 2021
@benjirewis benjirewis deleted the nullCheckBSONParse.3931 branch March 17, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazile-clyde bazile-clyde bazile-clyde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjirewis @bazile-clyde