CXX-3043 Address Coverity warnings for Ro3/Ro5 violations (#1142)

Author: eramongodb

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/array/value.hpp

@@ -76,8 +76,8 @@ class value {
     value(const value&);
     value& operator=(const value&);
 
-    value(value&&) noexcept = default;
-    value& operator=(value&&) noexcept = default;
+    value(value&&) = default;
+    value& operator=(value&&) = default;
 
     ///
     /// Get a view over the document owned by this value.

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/builder/basic/array.hpp

@@ -54,6 +54,9 @@ class array : public sub_array {
         return *this;
     }
 
+    array(const array&) = delete;
+    array& operator=(const array&) = delete;
+
     ///
     /// @return A view of the BSON array.
     ///

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/builder/basic/document.hpp

@@ -42,6 +42,8 @@ class document : public sub_document {
     ///
     BSONCXX_INLINE document() : sub_document(&_core), _core(false) {}
 
+    ~document() = default;
+
     ///
     /// Move constructor
     ///
@@ -56,6 +58,9 @@ class document : public sub_document {
         return *this;
     }
 
+    document(const document&) = delete;
+    document& operator=(const document&) = delete;
+
     ///
     /// @return A view of the BSON document.
     ///

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/builder/concatenate.hpp

@@ -32,10 +32,6 @@ namespace builder {
 struct concatenate_doc {
     document::view_or_value doc;
 
-    // MSVC seems to need a hint that it should always
-    // inline this destructor.
-    BSONCXX_INLINE ~concatenate_doc() = default;
-
     ///
     /// Conversion operator that provides a view of the wrapped concatenate
     /// document.
@@ -64,10 +60,6 @@ struct concatenate_doc {
 struct concatenate_array {
     array::view_or_value array;
 
-    // MSVC seems to need a hint that it should always
-    // inline this destructor.
-    BSONCXX_INLINE ~concatenate_array() = default;
-
     ///
     /// Conversion operator that provides a view of the wrapped concatenate
     /// array.

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/builder/core.hpp

@@ -59,6 +59,9 @@ class core {
 
     ~core();
 
+    core(const core&) = delete;
+    core& operator=(const core&) = delete;
+
     ///
     /// Appends a key passed as a non-owning stdx::string_view.
     ///

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/document/value.hpp

@@ -75,11 +75,13 @@ class value {
     ///
     explicit value(document::view view);
 
+    ~value() = default;
+
     value(const value&);
     value& operator=(const value&);
 
-    value(value&&) noexcept = default;
-    value& operator=(value&&) noexcept = default;
+    value(value&&) = default;
+    value& operator=(value&&) = default;
 
     ///
     /// Constructor used for serialization of user objects. This uses argument-dependent lookup

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/string/view_or_value.hpp

@@ -45,7 +45,7 @@ class view_or_value : public bsoncxx::v_noabi::view_or_value<stdx::string_view,
     ///
     /// Default constructor, equivalent to using an empty string.
     ///
-    BSONCXX_INLINE view_or_value() = default;
+    view_or_value() = default;
 
     ///
     /// Construct a string::view_or_value using a null-terminated const char *.

src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/view_or_value.hpp

@@ -46,11 +46,16 @@ class view_or_value {
     static_assert(std::is_default_constructible<View>::value,
                   "View type must be default constructible");
 
+    ///
+    /// Destroys a view_or_value.
+    ///
+    ~view_or_value() = default;
+
     ///
     /// Default-constructs a view_or_value. This is equivalent to constructing a
     /// view_or_value with a default-constructed View.
     ///
-    BSONCXX_INLINE view_or_value() = default;
+    view_or_value() = default;
 
     ///
     /// Construct a view_or_value from a View. When constructed with a View,

src/bsoncxx/lib/bsoncxx/v_noabi/bsoncxx/private/itoa.hh

@@ -27,6 +27,11 @@ class BSONCXX_TEST_API itoa {
    public:
     explicit itoa(uint32_t i = 0);
 
+    ~itoa() = default;
+
+    itoa(itoa&& rhs) = delete;
+    itoa& operator=(itoa&&) = delete;
+
     itoa(const itoa& rhs) = delete;
     itoa& operator=(const itoa&) = delete;
 

src/bsoncxx/lib/bsoncxx/v_noabi/bsoncxx/private/stack.hh

@@ -55,6 +55,12 @@ class stack {
         }
     }
 
+    stack(stack&&) = delete;
+    stack& operator=(stack&&) = delete;
+
+    stack(const stack&) = delete;
+    stack& operator=(const stack&) = delete;
+
     bool empty() const {
         return _is_empty;
     }

src/mongocxx/include/mongocxx/v_noabi/mongocxx/client.hpp

@@ -96,6 +96,9 @@ class client {
     ///
     ~client();
 
+    client(const client&) = delete;
+    client& operator=(const client&) = delete;
+
     ///
     /// Returns true if the client is valid, meaning it was not default constructed
     /// or moved from.

src/mongocxx/include/mongocxx/v_noabi/mongocxx/client_encryption.hpp

@@ -53,17 +53,17 @@ class client_encryption {
     ///
     /// Destroys a client_encryption.
     ///
-    ~client_encryption() noexcept;
+    ~client_encryption();
 
     ///
     /// Move-constructs a client_encryption object.
     ///
-    client_encryption(client_encryption&&);
+    client_encryption(client_encryption&&) noexcept;
 
     ///
     /// Move-assigns a client_encryption object.
     ///
-    client_encryption& operator=(client_encryption&&);
+    client_encryption& operator=(client_encryption&&) noexcept;
 
     client_encryption(const client_encryption&) = delete;
     client_encryption& operator=(const client_encryption&) = delete;

src/mongocxx/include/mongocxx/v_noabi/mongocxx/cursor.hpp

@@ -60,6 +60,9 @@ class cursor {
     ///
     ~cursor();
 
+    cursor(const cursor&) = delete;
+    cursor& operator=(const cursor&) = delete;
+
     ///
     /// A cursor::iterator that points to the beginning of any available
     /// results.  If begin() is called more than once, the cursor::iterator

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/command_failed_event.hpp

@@ -43,6 +43,12 @@ class command_failed_event {
     ///
     ~command_failed_event();
 
+    command_failed_event(command_failed_event&&) = default;
+    command_failed_event& operator=(command_failed_event&&) = default;
+
+    command_failed_event(const command_failed_event&) = default;
+    command_failed_event& operator=(const command_failed_event&) = default;
+
     ///
     /// Returns the server’s reply to the failed operation.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/command_started_event.hpp

@@ -43,6 +43,12 @@ class command_started_event {
     ///
     ~command_started_event();
 
+    command_started_event(command_started_event&&) = default;
+    command_started_event& operator=(command_started_event&&) = default;
+
+    command_started_event(const command_started_event&) = default;
+    command_started_event& operator=(const command_started_event&) = default;
+
     ///
     /// Returns the command that has been started.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/command_succeeded_event.hpp

@@ -43,6 +43,12 @@ class command_succeeded_event {
     ///
     ~command_succeeded_event();
 
+    command_succeeded_event(command_succeeded_event&&) = default;
+    command_succeeded_event& operator=(command_succeeded_event&&) = default;
+
+    command_succeeded_event(const command_succeeded_event&) = default;
+    command_succeeded_event& operator=(const command_succeeded_event&) = default;
+
     ///
     /// Returns the server reply for the succeeded operation.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/heartbeat_failed_event.hpp

@@ -42,6 +42,12 @@ class heartbeat_failed_event {
     ///
     ~heartbeat_failed_event();
 
+    heartbeat_failed_event(heartbeat_failed_event&&) = default;
+    heartbeat_failed_event& operator=(heartbeat_failed_event&&) = default;
+
+    heartbeat_failed_event(const heartbeat_failed_event&) = default;
+    heartbeat_failed_event& operator=(const heartbeat_failed_event&) = default;
+
     ///
     /// Returns the failed operation's error message.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/heartbeat_started_event.hpp

@@ -42,6 +42,12 @@ class heartbeat_started_event {
     ///
     ~heartbeat_started_event();
 
+    heartbeat_started_event(heartbeat_started_event&&) = default;
+    heartbeat_started_event& operator=(heartbeat_started_event&&) noexcept = default;
+
+    heartbeat_started_event(const heartbeat_started_event&) = default;
+    heartbeat_started_event& operator=(const heartbeat_started_event&) = default;
+
     ///
     /// Returns the host name.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/heartbeat_succeeded_event.hpp

@@ -41,6 +41,12 @@ class heartbeat_succeeded_event {
     ///
     ~heartbeat_succeeded_event();
 
+    heartbeat_succeeded_event(heartbeat_succeeded_event&&) = default;
+    heartbeat_succeeded_event& operator=(heartbeat_succeeded_event&&) = default;
+
+    heartbeat_succeeded_event(const heartbeat_succeeded_event&) = default;
+    heartbeat_succeeded_event& operator=(const heartbeat_succeeded_event&) = default;
+
     ///
     /// Returns the server reply for the succeeded operation.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/server_changed_event.hpp

@@ -42,6 +42,12 @@ class server_changed_event {
     ///
     ~server_changed_event();
 
+    server_changed_event(server_changed_event&&) = default;
+    server_changed_event& operator=(server_changed_event&&) = default;
+
+    server_changed_event(const server_changed_event&) = default;
+    server_changed_event& operator=(const server_changed_event&) = default;
+
     ///
     /// Returns the server host name.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/server_closed_event.hpp

@@ -43,6 +43,12 @@ class server_closed_event {
     ///
     ~server_closed_event();
 
+    server_closed_event(server_closed_event&&) = default;
+    server_closed_event& operator=(server_closed_event&&) = default;
+
+    server_closed_event(const server_closed_event&) = default;
+    server_closed_event& operator=(const server_closed_event&) = default;
+
     ///
     /// Returns the server host name.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/server_description.hpp

@@ -37,6 +37,12 @@ class server_description {
     ///
     ~server_description();
 
+    server_description(server_description&&) = default;
+    server_description& operator=(server_description&&) = default;
+
+    server_description(const server_description&) = default;
+    server_description& operator=(const server_description&) = default;
+
     ///
     /// An opaque id, unique to this server for this mongocxx::v_noabi::client or
     /// mongocxx::v_noabi::pool.

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/server_opening_event.hpp

@@ -42,6 +42,12 @@ class server_opening_event {
     ///
     ~server_opening_event();
 
+    server_opening_event(server_opening_event&&) = default;
+    server_opening_event& operator=(server_opening_event&&) = default;
+
+    server_opening_event(const server_opening_event&) = default;
+    server_opening_event& operator=(const server_opening_event&) = default;
+
     ///
     /// Returns the server host name.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/topology_changed_event.hpp

@@ -41,6 +41,12 @@ class topology_changed_event {
     ///
     ~topology_changed_event();
 
+    topology_changed_event(topology_changed_event&&) = default;
+    topology_changed_event& operator=(topology_changed_event&&) = default;
+
+    topology_changed_event(const topology_changed_event&) = default;
+    topology_changed_event& operator=(const topology_changed_event&) = default;
+
     ///
     /// An opaque id, unique to this topology for this mongocxx::v_noabi::client or
     /// mongocxx::v_noabi::pool.

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/topology_closed_event.hpp

@@ -40,6 +40,12 @@ class topology_closed_event {
     ///
     ~topology_closed_event();
 
+    topology_closed_event(topology_closed_event&&) = default;
+    topology_closed_event& operator=(topology_closed_event&&) = default;
+
+    topology_closed_event(const topology_closed_event&) = default;
+    topology_closed_event& operator=(const topology_closed_event&) = default;
+
     ///
     /// An opaque id, unique to this topology for this mongocxx::v_noabi::client or
     /// mongocxx::v_noabi::pool.

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/topology_description.hpp

@@ -119,6 +119,12 @@ class topology_description {
     ///
     ~topology_description();
 
+    topology_description(topology_description&&) = default;
+    topology_description& operator=(topology_description&&) = default;
+
+    topology_description(const topology_description&) = default;
+    topology_description& operator=(const topology_description&) = default;
+
     ///
     /// The topology type: "Unknown", "Sharded", "ReplicaSetNoPrimary", "ReplicaSetWithPrimary", or
     /// "Single".

src/mongocxx/include/mongocxx/v_noabi/mongocxx/events/topology_opening_event.hpp

@@ -40,6 +40,12 @@ class topology_opening_event {
     ///
     ~topology_opening_event();
 
+    topology_opening_event(topology_opening_event&&) = default;
+    topology_opening_event& operator=(topology_opening_event&&) = default;
+
+    topology_opening_event(const topology_opening_event&) = default;
+    topology_opening_event& operator=(const topology_opening_event&) = default;
+
     ///
     /// An opaque id, unique to this topology for this mongocxx::v_noabi::client or
     /// mongocxx::v_noabi::pool.

src/mongocxx/include/mongocxx/v_noabi/mongocxx/index_model.hpp

@@ -53,7 +53,10 @@ class index_model {
     ///
     index_model(const index_model&);
 
-    index_model& operator=(const index_model&) = delete;
+    ///
+    /// Copy assigns an index_model.
+    ///
+    index_model& operator=(const index_model&) = default;
 
     ///
     /// Destroys an index_model.

src/mongocxx/include/mongocxx/v_noabi/mongocxx/index_view.hpp

@@ -42,6 +42,9 @@ class index_view {
 
     ~index_view();
 
+    index_view(const index_view&) = delete;
+    index_view& operator=(const index_view&) = delete;
+
     ///
     /// @{
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/instance.hpp

@@ -107,6 +107,9 @@ class instance {
     ///
     ~instance();
 
+    instance(const instance&) = delete;
+    instance& operator=(const instance&) = delete;
+
     ///
     /// Returns the current unique instance of the driver. If an instance was explicitly created,
     /// that will be returned. If no instance has yet been created, a default instance will be