Skip to content

Commit 22d6f93

Browse files
committed
CXX-1719 should use majority wc for commitTxn
1 parent 50627c9 commit 22d6f93

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

data/transactions/run-command.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@
248248
},
249249
{
250250
"description": "run command fails with explicit secondary read preference",
251+
"skipReason": "read preferences in database::run_command are not supported",
251252
"operations": [
252253
{
253254
"name": "startTransaction",

src/mongocxx/test/spec/transactions.cpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,7 @@ void run_transactions_tests_in_file(const std::string& test_path) {
202202
bool fail_point_enabled = (bool)test["failPoint"];
203203
auto description = test["description"].get_utf8().value;
204204
INFO("Test description: " << description);
205-
if (description.compare("run command fails with explicit secondary read preference") == 0) {
206-
WARN("Skipping test - read preferences in database::run_command are not supported");
205+
if (should_skip_spec_test(client{uri{}}, test.get_document().value)) {
207206
continue;
208207
}
209208

@@ -383,12 +382,6 @@ TEST_CASE("Transactions spec automated tests", "[transactions_spec]") {
383382
path.pop_back();
384383
}
385384

386-
client client{uri{}};
387-
if (test_util::get_max_wire_version(client) < 7) {
388-
WARN("Skipping - max wire version is < 7");
389-
return;
390-
}
391-
392385
std::ifstream test_files{path + "/test_files.txt"};
393386
REQUIRE(test_files.good());
394387

0 commit comments

Comments
 (0)