CXX-1643 Replace mongoc_uri_new for better exception message (#720)

Author: rayangler

src/mongocxx/private/libmongoc_symbols.hh

@@ -308,7 +308,7 @@ MONGOCXX_LIBMONGOC_SYMBOL(uri_get_tls)
 MONGOCXX_LIBMONGOC_SYMBOL(uri_get_string)
 MONGOCXX_LIBMONGOC_SYMBOL(uri_get_username)
 MONGOCXX_LIBMONGOC_SYMBOL(uri_get_write_concern)
-MONGOCXX_LIBMONGOC_SYMBOL(uri_new)
+MONGOCXX_LIBMONGOC_SYMBOL(uri_new_with_error)
 MONGOCXX_LIBMONGOC_SYMBOL(write_concern_copy)
 MONGOCXX_LIBMONGOC_SYMBOL(write_concern_destroy)
 MONGOCXX_LIBMONGOC_SYMBOL(write_concern_get_journal)

src/mongocxx/test/uri.cpp

@@ -71,6 +71,11 @@ TEST_CASE("URI", "[uri]") {
             mongocxx::uri{invalid};
         } catch (const mongocxx::logic_error& e) {
             REQUIRE(e.code() == mongocxx::error_code::k_invalid_uri);
+
+            std::string invalid_schema =
+                "Invalid URI Schema, expecting 'mongodb://' or 'mongodb+srv://': ";
+
+            REQUIRE(e.what() == invalid_schema + e.code().message());
         }
     }
 

src/mongocxx/uri.cpp

@@ -48,10 +48,14 @@ uri::uri(std::unique_ptr<impl>&& implementation) {
     _impl.reset(implementation.release());
 }
 
-uri::uri(bsoncxx::string::view_or_value uri_string)
-    : _impl(stdx::make_unique<impl>(libmongoc::uri_new(uri_string.terminated().data()))) {
+uri::uri(bsoncxx::string::view_or_value uri_string) {
+    bson_error_t error;
+
+    _impl = stdx::make_unique<impl>(
+        libmongoc::uri_new_with_error(uri_string.terminated().data(), &error));
+
     if (_impl->uri_t == nullptr) {
-        throw logic_error{error_code::k_invalid_uri};
+        throw logic_error{error_code::k_invalid_uri, error.message};
     }
 }