CXX-2790 Redeclare mongocxx::v_noabi as a non-inline namespace (#1070)

* Redeclare mongocxx::v_noabi as a non-inline namespace

* Fix additional root namespace references missing ABI namespace qualifier

* ABI-qualify all references to bsoncxx in mongocxx::v_noabi

Author: eramongodb

src/mongocxx/include/mongocxx/v_noabi/mongocxx/bulk_write-fwd.hpp

@@ -17,7 +17,17 @@
 #include <mongocxx/config/prelude.hpp>
 
 namespace mongocxx {
-inline namespace v_noabi { class MONGOCXX_API bulk_write; }  // namespace v_noabi
+namespace v_noabi {
+
+class MONGOCXX_API bulk_write;
+
+}  // namespace v_noabi
+}  // namespace mongocxx
+
+namespace mongocxx {
+
+using ::mongocxx::v_noabi::bulk_write;
+
 }  // namespace mongocxx
 
 #include <mongocxx/config/postlude.hpp>

src/mongocxx/include/mongocxx/v_noabi/mongocxx/bulk_write.hpp

@@ -25,7 +25,8 @@
 #include <mongocxx/config/prelude.hpp>
 
 namespace mongocxx {
-inline namespace v_noabi {
+namespace v_noabi {
+
 ///
 /// Class representing a batch of write operations that can be sent to the server as a group.
 ///
@@ -77,14 +78,14 @@ class bulk_write {
     ///   A reference to the object on which this member function is being called. This facilitates
     ///   method chaining.
     ///
-    /// @throws mongocxx::logic_error if the given operation is invalid.
+    /// @throws mongocxx::v_noabi::logic_error if the given operation is invalid.
     ///
     bulk_write& append(const model::write& operation);
 
     ///
     /// Executes a bulk write.
     ///
-    /// @throws mongocxx::bulk_write_exception when there are errors processing the writes.
+    /// @throws mongocxx::v_noabi::bulk_write_exception when there are errors processing the writes.
     ///
     /// @return The optional result of the bulk operation execution, a result::bulk_write.
     ///

src/mongocxx/include/mongocxx/v_noabi/mongocxx/change_stream-fwd.hpp

@@ -17,7 +17,17 @@
 #include <mongocxx/config/prelude.hpp>
 
 namespace mongocxx {
-inline namespace v_noabi { class MONGOCXX_API change_stream; }  // namespace v_noabi
+namespace v_noabi {
+
+class MONGOCXX_API change_stream;
+
+}  // namespace v_noabi
+}  // namespace mongocxx
+
+namespace mongocxx {
+
+using ::mongocxx::v_noabi::change_stream;
+
 }  // namespace mongocxx
 
 #include <mongocxx/config/postlude.hpp>

src/mongocxx/include/mongocxx/v_noabi/mongocxx/change_stream.hpp

@@ -27,7 +27,8 @@
 #include <mongocxx/config/prelude.hpp>
 
 namespace mongocxx {
-inline namespace v_noabi {
+namespace v_noabi {
+
 ///
 /// Class representing a MongoDB change stream.
 ///
@@ -69,7 +70,7 @@ class change_stream {
     /// @return
     ///   The change_stream::iterator
     /// @exception
-    ///   Throws mongocxx::query_exception if the query failed.
+    ///   Throws mongocxx::v_noabi::query_exception if the query failed.
     ///
     iterator begin() const;
 
@@ -105,7 +106,7 @@ class change_stream {
     /// @return
     ///   The token.
     ///
-    bsoncxx::stdx::optional<bsoncxx::document::view> get_resume_token() const;
+    bsoncxx::v_noabi::stdx::optional<bsoncxx::v_noabi::document::view> get_resume_token() const;
 
    private:
     friend ::mongocxx::v_noabi::client;
@@ -127,7 +128,7 @@ class change_stream::iterator {
    public:
     // Support input-iterator (caveat of post-increment returning void)
     using difference_type = std::int64_t;
-    using value_type = const bsoncxx::document::view;
+    using value_type = const bsoncxx::v_noabi::document::view;
     using pointer = std::add_pointer<value_type>::type;
     using reference = std::add_lvalue_reference<value_type>::type;
     using iterator_category = std::input_iterator_tag;
@@ -145,15 +146,15 @@ class change_stream::iterator {
     /// The returned document::view is valid until the iterator is incremented. The value may be
     /// copied to extend its lifetime.
     ///
-    const bsoncxx::document::view& operator*() const;
+    const bsoncxx::v_noabi::document::view& operator*() const;
 
     ///
     /// Accesses a member of the dereferenced document currently being pointed to.
     ///
     /// The returned document::view is valid until the iterator is incremented. The value may be
     /// copied to extend its lifetime.
     ///
-    const bsoncxx::document::view* operator->() const;
+    const bsoncxx::v_noabi::document::view* operator->() const;
 
     ///
     /// Pre-increments the iterator to move to the next document.
@@ -166,7 +167,7 @@ class change_stream::iterator {
     /// If no notification is available, callers may call change_stream::begin() to check for more
     /// notifications.
     ///
-    /// @throws mongocxx::query_exception if the query failed
+    /// @throws mongocxx::v_noabi::query_exception if the query failed
     ///
     iterator& operator++();
 
@@ -181,7 +182,7 @@ class change_stream::iterator {
     /// If no notification is available, callers may call change_stream::begin() to check for more
     /// notifications.
     ///
-    /// @throws mongocxx::query_exception if the query failed
+    /// @throws mongocxx::v_noabi::query_exception if the query failed
     ///
     void operator++(int);
 

src/mongocxx/include/mongocxx/v_noabi/mongocxx/client-fwd.hpp

@@ -17,7 +17,17 @@
 #include <mongocxx/config/prelude.hpp>
 
 namespace mongocxx {
-inline namespace v_noabi { class MONGOCXX_API client; }  // namespace v_noabi
+namespace v_noabi {
+
+class MONGOCXX_API client;
+
+}  // namespace v_noabi
+}  // namespace mongocxx
+
+namespace mongocxx {
+
+using ::mongocxx::v_noabi::client;
+
 }  // namespace mongocxx
 
 #include <mongocxx/config/postlude.hpp>