GODRIVER-1562 Wrap driver.ErrUnacknowledgedWrite in BulkWrite (#361)

Author: Divjot Arora

mongo/bulk_write.go

@@ -75,7 +75,9 @@ func (bw *bulkWrite) execute(ctx context.Context) error {
 
 		bwErr.WriteErrors = append(bwErr.WriteErrors, batchErr.WriteErrors...)
 
-		if !continueOnError && (err != nil || len(batchErr.WriteErrors) > 0 || batchErr.WriteConcernError != nil) {
+		commandErrorOccurred := err != nil && err != driver.ErrUnacknowledgedWrite
+		writeErrorOccurred := len(batchErr.WriteErrors) > 0 || batchErr.WriteConcernError != nil
+		if !continueOnError && (commandErrorOccurred || writeErrorOccurred) {
 			if err != nil {
 				return err
 			}
@@ -92,6 +94,7 @@ func (bw *bulkWrite) execute(ctx context.Context) error {
 
 	bw.result.MatchedCount -= bw.result.UpsertedCount
 	if lastErr != nil {
+		_, lastErr = processWriteError(lastErr)
 		return lastErr
 	}
 	if len(bwErr.WriteErrors) > 0 || bwErr.WriteConcernError != nil {

mongo/integration/collection_test.go

@@ -993,6 +993,22 @@ func TestCollection(t *testing.T) {
 			assert.Equal(mt, expectedModel, actualModel, "expected model %v in BulkWriteException, got %v",
 				expectedModel, actualModel)
 		})
+		unackClientOpts := options.Client().
+			SetWriteConcern(writeconcern.New(writeconcern.W(0)))
+		unackMtOpts := mtest.NewOptions().
+			ClientOptions(unackClientOpts).
+			MinServerVersion("3.6")
+		mt.RunOpts("unacknowledged write", unackMtOpts, func(mt *mtest.T) {
+			models := []mongo.WriteModel{
+				mongo.NewInsertOneModel().SetDocument(bson.D{{"x", 1}}),
+			}
+			_, err := mt.Coll.BulkWrite(mtest.Background, models)
+			if err != mongo.ErrUnacknowledgedWrite {
+				// Use a direct comparison rather than assert.Equal because assert.Equal will compare the error strings,
+				// so the assertion would succeed even if the error had not been wrapped.
+				mt.Fatalf("expected BulkWrite error %v, got %v", mongo.ErrUnacknowledgedWrite, err)
+			}
+		})
 	})
 }