Skip to content

Commit d77ce02

Browse files
committed
Merge branch 'pr/80'
Change-Id: If42c34099c45b1a5932fb0471e17ba6624694cbd
2 parents a278f03 + a621684 commit d77ce02

File tree

5 files changed

+21
-19
lines changed

5 files changed

+21
-19
lines changed

core/connection/connection.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ func canMonitor(cmd string) bool {
358358
return true
359359
}
360360

361-
func (c *connection) commandStartedEvent(wm wiremessage.WireMessage) error {
361+
func (c *connection) commandStartedEvent(ctx context.Context, wm wiremessage.WireMessage) error {
362362
if c.cmdMonitor == nil || c.cmdMonitor.Started == nil {
363363
return nil
364364
}
@@ -417,7 +417,7 @@ func (c *connection) commandStartedEvent(wm wiremessage.WireMessage) error {
417417
startedEvent.Command = emptyDoc
418418
}
419419

420-
c.cmdMonitor.Started(startedEvent)
420+
c.cmdMonitor.Started(ctx, startedEvent)
421421

422422
if !acknowledged {
423423
if c.cmdMonitor.Succeeded == nil {
@@ -432,7 +432,7 @@ func (c *connection) commandStartedEvent(wm wiremessage.WireMessage) error {
432432
ConnectionID: c.id,
433433
}
434434

435-
c.cmdMonitor.Succeeded(&event.CommandSucceededEvent{
435+
c.cmdMonitor.Succeeded(ctx, &event.CommandSucceededEvent{
436436
CommandFinishedEvent: finishedEvent,
437437
Reply: bson.NewDocument(
438438
bson.EC.Int32("ok", 1),
@@ -489,7 +489,7 @@ func processReply(reply *bson.Document) (bool, string) {
489489
return false, fullErrMsg
490490
}
491491

492-
func (c *connection) commandFinishedEvent(wm wiremessage.WireMessage) error {
492+
func (c *connection) commandFinishedEvent(ctx context.Context, wm wiremessage.WireMessage) error {
493493
if c.cmdMonitor == nil {
494494
return nil
495495
}
@@ -532,7 +532,7 @@ func (c *connection) commandFinishedEvent(wm wiremessage.WireMessage) error {
532532
Reply: emptyDoc,
533533
CommandFinishedEvent: finishedEvent,
534534
}
535-
c.cmdMonitor.Succeeded(successEvent)
535+
c.cmdMonitor.Succeeded(ctx, successEvent)
536536
return nil
537537
}
538538

@@ -553,7 +553,7 @@ func (c *connection) commandFinishedEvent(wm wiremessage.WireMessage) error {
553553
CommandFinishedEvent: finishedEvent,
554554
}
555555

556-
c.cmdMonitor.Succeeded(successEvent)
556+
c.cmdMonitor.Succeeded(ctx, successEvent)
557557
return nil
558558
}
559559

@@ -562,7 +562,7 @@ func (c *connection) commandFinishedEvent(wm wiremessage.WireMessage) error {
562562
CommandFinishedEvent: finishedEvent,
563563
}
564564

565-
c.cmdMonitor.Failed(failureEvent)
565+
c.cmdMonitor.Failed(ctx, failureEvent)
566566
return nil
567567
}
568568

@@ -639,7 +639,7 @@ func (c *connection) WriteWireMessage(ctx context.Context, wm wiremessage.WireMe
639639
}
640640

641641
c.bumpIdleDeadline()
642-
err = c.commandStartedEvent(wm)
642+
err = c.commandStartedEvent(ctx, wm)
643643
if err != nil {
644644
return err
645645
}
@@ -790,7 +790,7 @@ func (c *connection) ReadWireMessage(ctx context.Context) (wiremessage.WireMessa
790790
}
791791

792792
c.bumpIdleDeadline()
793-
err = c.commandFinishedEvent(wm)
793+
err = c.commandFinishedEvent(ctx, wm)
794794
if err != nil {
795795
return nil, err // TODO: do we care if monitoring fails?
796796
}

core/event/monitoring.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
package event
88

99
import (
10+
"context"
1011
"time"
1112

1213
"github.com/mongodb/mongo-go-driver/bson"
@@ -64,7 +65,7 @@ type CommandFailedEvent struct {
6465

6566
// CommandMonitor represents a monitor that is triggered for different events.
6667
type CommandMonitor struct {
67-
Started func(*CommandStartedEvent)
68-
Succeeded func(*CommandSucceededEvent)
69-
Failed func(*CommandFailedEvent)
68+
Started func(context.Context, *CommandStartedEvent)
69+
Succeeded func(context.Context, *CommandSucceededEvent)
70+
Failed func(context.Context, *CommandFailedEvent)
7071
}

mongo/causal_consistency_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
package mongo
88

99
import (
10+
"context"
1011
"os"
1112
"reflect"
1213
"testing"
@@ -23,10 +24,10 @@ var ccStarted *event.CommandStartedEvent
2324
var ccSucceeded *event.CommandSucceededEvent
2425

2526
var ccMonitor = &event.CommandMonitor{
26-
Started: func(cse *event.CommandStartedEvent) {
27+
Started: func(ctx context.Context, cse *event.CommandStartedEvent) {
2728
ccStarted = cse
2829
},
29-
Succeeded: func(cse *event.CommandSucceededEvent) {
30+
Succeeded: func(ctx context.Context, cse *event.CommandSucceededEvent) {
3031
ccSucceeded = cse
3132
},
3233
}

mongo/command_monitoring_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ var failedChan = make(chan *event.CommandFailedEvent, 100)
3838
var cursorID int64
3939

4040
var monitor = &event.CommandMonitor{
41-
Started: func(cse *event.CommandStartedEvent) {
41+
Started: func(ctx context.Context, cse *event.CommandStartedEvent) {
4242
startedChan <- cse
4343
},
44-
Succeeded: func(cse *event.CommandSucceededEvent) {
44+
Succeeded: func(ctx context.Context, cse *event.CommandSucceededEvent) {
4545
succeededChan <- cse
4646
},
47-
Failed: func(cfe *event.CommandFailedEvent) {
47+
Failed: func(ctx context.Context, cfe *event.CommandFailedEvent) {
4848
failedChan <- cfe
4949
},
5050
}

mongo/sessions_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ var sessionSucceeded *event.CommandSucceededEvent
5353
var sessionsMonitoredTop *topology.Topology
5454

5555
var sessionsMonitor = &event.CommandMonitor{
56-
Started: func(cse *event.CommandStartedEvent) {
56+
Started: func(ctx context.Context, cse *event.CommandStartedEvent) {
5757
sessionStarted = cse
5858
},
59-
Succeeded: func(cse *event.CommandSucceededEvent) {
59+
Succeeded: func(ctx context.Context, cse *event.CommandSucceededEvent) {
6060
sessionSucceeded = cse
6161
},
6262
}

0 commit comments

Comments
 (0)