Skip to content

GODRIVER-1535 Fix session IDs batching in Disconnect #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

divjotarora
Copy link
Contributor

No description provided.

@divjotarora divjotarora requested review from jyemin and iwysiu March 23, 2020 22:01
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler. I think I found a missing test case, so I'd like to see that added.

@divjotarora divjotarora requested a review from jyemin March 26, 2020 19:59
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one comment nit, but no need for re-review

LGTM

_ = coll.Drop(bgCtx)
}()

// Do an application operation and create four sessions so endSessions will execute in two batches.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer always four

@divjotarora divjotarora force-pushed the godriver1535-endsessions-batching branch from 5a8016c to d844185 Compare March 26, 2020 20:25
@divjotarora divjotarora merged commit 218a07c into mongodb:master Mar 26, 2020
@divjotarora divjotarora deleted the godriver1535-endsessions-batching branch March 26, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants