Skip to content

GODRIVER-1682 - Use typeDecoder in recursive decoders #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2020
Merged

GODRIVER-1682 - Use typeDecoder in recursive decoders #465

merged 2 commits into from
Jul 27, 2020

Conversation

divjotarora
Copy link
Contributor

No description provided.

@divjotarora divjotarora force-pushed the godriver1682-recursive-typeDecoder branch 2 times, most recently from 0daa2cc to 46b4326 Compare July 25, 2020 02:28
craiggwilson
craiggwilson reviewed Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@craiggwilson craiggwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test for this?

@divjotarora
Copy link
Contributor Author

@craiggwilson I added some tests to make sure the conversions are done properly, but they won't be useful until #448 is merged because there are no typeDecoder implementations yet, so everything is still going through the DecodeValue path. I ensured they pass on a branch that has all of the changes, though, and I'll rebase/force-push this branch once the other PR is merged too.

@divjotarora divjotarora requested a review from craiggwilson July 27, 2020 16:08
@divjotarora divjotarora force-pushed the godriver1682-recursive-typeDecoder branch from b2dd6bf to 21fc394 Compare July 27, 2020 16:09
@divjotarora divjotarora merged commit 488c521 into mongodb:master Jul 27, 2020
@divjotarora divjotarora deleted the godriver1682-recursive-typeDecoder branch July 27, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craiggwilson craiggwilson craiggwilson approved these changes

@iwysiu iwysiu iwysiu approved these changes

@jyemin jyemin Awaiting requested review from jyemin

@KritiRav KritiRav Awaiting requested review from KritiRav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divjotarora @craiggwilson @iwysiu