Fixed HHVM-180: Throw exception if Timestamp arguments are out of range

derickr · derickr · commit 1608846e7e97 · 2016-02-29T12:08:53.000Z
diff --git a/ext_mongodb.php b/ext_mongodb.php
@@ -758,6 +758,14 @@ final class Timestamp implements Type, \Serializable
 
 	public function __construct(private int $increment, private int $timestamp)
 	{
+		if ( $increment < 0 || $increment > 4294967295 )
+		{
+			throw new \MongoDB\Driver\Exception\InvalidArgumentException( "Expected increment to be an unsigned 32-bit integer, {$increment} given" );
+		}
+		if ( $timestamp < 0 || $timestamp > 4294967295 )
+		{
+			throw new \MongoDB\Driver\Exception\InvalidArgumentException( "Expected timestamp to be an unsigned 32-bit integer, {$timestamp} given" );
+		}
 	}
 
 	public function __toString() : string

Original file line number	Diff line number	Diff line change
`@@ -758,6 +758,14 @@ final class Timestamp implements Type, \Serializable`
`758`	`758`
`759`	`759`	`public function __construct(private int $increment, private int $timestamp)`
`760`	`760`	`{`
	`761`	`+ if ( $increment < 0 \|\| $increment > 4294967295 )`
	`762`	`+ {`
	`763`	`+ throw new \MongoDB\Driver\Exception\InvalidArgumentException( "Expected increment to be an unsigned 32-bit integer, {$increment} given" );`
	`764`	`+ }`
	`765`	`+ if ( $timestamp < 0 \|\| $timestamp > 4294967295 )`
	`766`	`+ {`
	`767`	`+ throw new \MongoDB\Driver\Exception\InvalidArgumentException( "Expected timestamp to be an unsigned 32-bit integer, {$timestamp} given" );`
	`768`	`+ }`
`761`	`769`	`}`
`762`	`770`
`763`	`771`	`public function __toString() : string`