HHVM-204: WriteResult::isAcknowledged() should use mongoc_write_concern_is_acknowledged()

Author: derickr

config.cmake

@@ -33,6 +33,7 @@ HHVM_EXTENSION(mongodb
  libbson/src/bson/bson-timegm.c libbson/src/bson/bson-utf8.c
  libbson/src/bson/bson-value.c libbson/src/bson/bson-version-functions.c
  libbson/src/bson/bson-writer.c libbson/src/bson/bson.c
+ libmongoc/src/mongoc/mongoc-apm.c
  libmongoc/src/mongoc/mongoc-async.c
  libmongoc/src/mongoc/mongoc-async-cmd.c
  libmongoc/src/mongoc/mongoc-array.c libmongoc/src/mongoc/mongoc-b64.c
@@ -46,6 +47,7 @@ HHVM_EXTENSION(mongodb
  libmongoc/src/mongoc/mongoc-crypto-openssl.c
  libmongoc/src/mongoc/mongoc-cursor-array.c
  libmongoc/src/mongoc/mongoc-cursor-cursorid.c
+ libmongoc/src/mongoc/mongoc-cursor-transform.c
  libmongoc/src/mongoc/mongoc-cursor.c libmongoc/src/mongoc/mongoc-database.c
  libmongoc/src/mongoc/mongoc-find-and-modify.c
  libmongoc/src/mongoc/mongoc-gridfs-file-list.c
@@ -64,6 +66,7 @@ HHVM_EXTENSION(mongodb
  libmongoc/src/mongoc/mongoc-read-concern.c
  libmongoc/src/mongoc/mongoc-read-prefs.c libmongoc/src/mongoc/mongoc-rpc.c
  libmongoc/src/mongoc/mongoc-sasl.c libmongoc/src/mongoc/mongoc-scram.c
+ libmongoc/src/mongoc/mongoc-secure-transport.c
  libmongoc/src/mongoc/mongoc-server-description.c
  libmongoc/src/mongoc/mongoc-server-stream.c
  libmongoc/src/mongoc/mongoc-set.c
@@ -93,7 +96,6 @@ HHVM_LINK_LIBRARIES(mongodb ${SASL_LIBRARIES})
 HHVM_DEFINE(mongodb "-DBSON_COMPILATION=1")
 HHVM_DEFINE(mongodb "-DMONGOC_COMPILATION=1")
 HHVM_DEFINE(mongodb "-DMONGOC_ENABLE_CRYPTO")
-HHVM_DEFINE(mongodb "-DMONGOC_ENABLE_OPENSSL")
 HHVM_DEFINE(mongodb "-DMONGOC_ENABLE_SSL")
 HHVM_DEFINE(mongodb "-DMONGOC_ENABLE_SASL")
 HHVM_DEFINE(mongodb "-DMONGOC_TRACE=1")

src/MongoDB/Driver/WriteResult.cpp

@@ -54,7 +54,7 @@ bool HHVM_METHOD(MongoDBDriverWriteResult, isAcknowledged)
 {
 	MongoDBDriverWriteResultData* data = Native::data<MongoDBDriverWriteResultData>(this_);
 
-	return !!_mongoc_write_concern_needs_gle(data->m_write_concern);
+	return mongoc_write_concern_is_acknowledged(data->m_write_concern);
 }
 
 const StaticString