Also allow for the fully lower case version of the option

Author: derickr

src/MongoDB/Driver/Manager.cpp

@@ -51,6 +51,7 @@ const StaticString
 	s_MongoDBDriverManager_slaveok("slaveok"),
 	s_MongoDBDriverManager_readpreference("readpreference"),
 	s_MongoDBDriverManager_readpreferencetags("readpreferencetags"),
+	s_MongoDBDriverManager_maxstalenessms("maxstalenessms"),
 	s_MongoDBDriverManager_readPreference("readPreference"),
 	s_MongoDBDriverManager_readPreferenceTags("readPreferenceTags"),
 	s_MongoDBDriverManager_maxStalenessMS("maxStalenessMS"),
@@ -135,6 +136,7 @@ static bool hippo_mongo_driver_manager_apply_rp(mongoc_uri_t *uri, const Array o
 		!options.exists(s_MongoDBDriverManager_slaveok) &&
 		!options.exists(s_MongoDBDriverManager_readpreference) &&
 		!options.exists(s_MongoDBDriverManager_readpreferencetags) &&
+		!options.exists(s_MongoDBDriverManager_maxstalenessms) &&
 		!options.exists(s_MongoDBDriverManager_readPreference) &&
 		!options.exists(s_MongoDBDriverManager_readPreferenceTags) &&
 		!options.exists(s_MongoDBDriverManager_maxStalenessMS)
@@ -197,15 +199,23 @@ static bool hippo_mongo_driver_manager_apply_rp(mongoc_uri_t *uri, const Array o
 	}
 
 	/* Handle maxStalenessMS, and make sure it is not combined with PRIMARY readPreference */
-	if (options.exists(s_MongoDBDriverManager_maxStalenessMS) && options[s_MongoDBDriverManager_maxStalenessMS].isInteger()) {
+	if (
+		(options.exists(s_MongoDBDriverManager_maxstalenessms) && options[s_MongoDBDriverManager_maxstalenessms].isInteger())
+		||
+		(options.exists(s_MongoDBDriverManager_maxStalenessMS) && options[s_MongoDBDriverManager_maxStalenessMS].isInteger())
+	) {
 		if (mongoc_read_prefs_get_mode(new_rp) == MONGOC_READ_PRIMARY) {
 			throw MongoDriver::Utils::throwInvalidArgumentException("Primary read preference mode conflicts with maxStalenessMS");
 			mongoc_read_prefs_destroy(new_rp);
 
 			return false;
 		}
 
-		mongoc_read_prefs_set_max_staleness_ms(new_rp, (int32_t) options[s_MongoDBDriverManager_maxStalenessMS].toInt64());
+		if (options.exists(s_MongoDBDriverManager_maxstalenessms)) {
+			mongoc_read_prefs_set_max_staleness_ms(new_rp, (int32_t) options[s_MongoDBDriverManager_maxstalenessms].toInt64());
+		} else {
+			mongoc_read_prefs_set_max_staleness_ms(new_rp, (int32_t) options[s_MongoDBDriverManager_maxStalenessMS].toInt64());
+		}
 	}
 
 	/* This may be redundant in light of the check for primary with tags,

tests/MongoDBDriverManager_maxStalenessMS-001.phpt

@@ -5,6 +5,8 @@ MongoDB\Driver\Manager: maxStalenessMS
 // They both should work, and produce no output. We're not testing whether the flag actually does something
 $manager = new MongoDB\Driver\Manager("mongodb://localhost/?readPreference=SECONDARY&maxStalenessMS=1231");
 $manager = new MongoDB\Driver\Manager("mongodb://localhost/?readPreference=SECONDARY", [ 'maxStalenessMS' => 1231 ] );
+$manager = new MongoDB\Driver\Manager("mongodb://localhost/?readPreference=SECONDARY&maxstalenessms=1231");
+$manager = new MongoDB\Driver\Manager("mongodb://localhost/?readPreference=SECONDARY", [ 'maxstalenessms' => 1231 ] );
 ?>
 ==DONE==
 --EXPECTF--

tests/MongoDBDriverManager_maxStalenessMS_error-001.phpt

@@ -2,18 +2,32 @@
 MongoDB\Driver\Manager: maxStalenessMS
 --FILE--
 <?php
+try {
+	$manager = new MongoDB\Driver\Manager("mongodb://localhost/?maxstalenessms=1231");
+} catch ( MongoDB\Driver\Exception\InvalidArgumentException $e ) {
+	echo $e->getMessage(), "\n";
+}
+
 try {
 	$manager = new MongoDB\Driver\Manager("mongodb://localhost/?maxStalenessMS=1231");
 } catch ( MongoDB\Driver\Exception\InvalidArgumentException $e ) {
 	echo $e->getMessage(), "\n";
 }
 
+try {
+	$manager = new MongoDB\Driver\Manager("mongodb://localhost/", [ 'maxstalenessms' => 1231 ] );
+} catch ( MongoDB\Driver\Exception\InvalidArgumentException $e ) {
+	echo $e->getMessage(), "\n";
+}
+
 try {
 	$manager = new MongoDB\Driver\Manager("mongodb://localhost/", [ 'maxStalenessMS' => 1231 ] );
 } catch ( MongoDB\Driver\Exception\InvalidArgumentException $e ) {
 	echo $e->getMessage(), "\n";
 }
 ?>
 --EXPECTF--
+Failed to parse MongoDB URI: 'mongodb://localhost/?maxstalenessms=1231'
 Failed to parse MongoDB URI: 'mongodb://localhost/?maxStalenessMS=1231'
 Primary read preference mode conflicts with maxStalenessMS
+Primary read preference mode conflicts with maxStalenessMS