45
45
import static com .mongodb .ReadPreference .primary ;
46
46
import static com .mongodb .ReadPreference .primaryPreferred ;
47
47
import static com .mongodb .assertions .Assertions .assertFalse ;
48
+ import static com .mongodb .assertions .Assertions .assertTrue ;
48
49
import static com .mongodb .assertions .Assertions .notNull ;
49
50
import static com .mongodb .connection .ClusterConnectionMode .LOAD_BALANCED ;
50
51
import static com .mongodb .connection .ClusterConnectionMode .SINGLE ;
@@ -112,6 +113,7 @@ public final class CommandMessage extends RequestMessage {
112
113
this .payloadFieldNameValidator = payloadFieldNameValidator ;
113
114
this .clusterConnectionMode = notNull ("clusterConnectionMode" , clusterConnectionMode );
114
115
this .serverApi = serverApi ;
116
+ assertTrue (useOpMsg () || responseExpected );
115
117
}
116
118
117
119
/**
@@ -187,7 +189,11 @@ private String getSequenceIdentifier(final ByteBuf byteBuf) {
187
189
}
188
190
189
191
boolean isResponseExpected () {
190
- return !useOpMsg () || requireOpMsgResponse ();
192
+ if (responseExpected ) {
193
+ return true ;
194
+ } else {
195
+ return payload != null && payload .isOrdered () && payload .hasAnotherSplit ();
196
+ }
191
197
}
192
198
193
199
MongoNamespace getNamespace () {
@@ -240,7 +246,7 @@ protected EncodingMetadata encodeMessageBodyWithMetadata(final BsonOutput bsonOu
240
246
241
247
private int getOpMsgFlagBits () {
242
248
int flagBits = 0 ;
243
- if (!requireOpMsgResponse ()) {
249
+ if (!isResponseExpected ()) {
244
250
flagBits = 1 << 1 ;
245
251
}
246
252
if (exhaustAllowed ) {
@@ -249,14 +255,6 @@ private int getOpMsgFlagBits() {
249
255
return flagBits ;
250
256
}
251
257
252
- private boolean requireOpMsgResponse () {
253
- if (responseExpected ) {
254
- return true ;
255
- } else {
256
- return payload != null && payload .isOrdered () && payload .hasAnotherSplit ();
257
- }
258
- }
259
-
260
258
private boolean isDirectConnectionToReplicaSetMember () {
261
259
return clusterConnectionMode == SINGLE
262
260
&& getSettings ().getServerType () != SHARD_ROUTER
0 commit comments