Update driver-core/src/main/com/mongodb/internal/connection/OperationContext.java

stIncMale · katcharov · web-flow · commit 29ebd766acaa · 2024-05-01T20:19:57.000-06:00
Let's put various checks (validation, preconditions...) at the top of methods, with the operation at the bottom.

Co-authored-by: Maxim Katcharov &lt;maxim.katcharov@mongodb.com&gt;
diff --git a/driver-core/src/main/com/mongodb/internal/connection/OperationContext.java b/driver-core/src/main/com/mongodb/internal/connection/OperationContext.java
@@ -71,10 +71,11 @@ void updateCandidate(final ServerAddress serverAddress, final ClusterType cluste
         }
 
         public void onAttemptFailure(final Throwable failure) {
-            if (candidate != null && !(failure instanceof MongoConnectionPoolClearedException)) {
-                deprioritized.add(candidate);
+            if (candidate == null || failure instanceof MongoConnectionPoolClearedException) {
+                candidate = null;
+                return;
             }
-            candidate = null;
+            deprioritized.add(candidate);
         }
 
         private static boolean isEnabled(final ClusterType clusterType) {

Original file line number	Diff line number	Diff line change
`@@ -71,10 +71,11 @@ void updateCandidate(final ServerAddress serverAddress, final ClusterType cluste`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`public void onAttemptFailure(final Throwable failure) {`
`74`		`- if (candidate != null && !(failure instanceof MongoConnectionPoolClearedException)) {`
`75`		`- deprioritized.add(candidate);`
	`74`	`+ if (candidate == null \|\| failure instanceof MongoConnectionPoolClearedException) {`
	`75`	`+ candidate = null;`
	`76`	`+ return;`
`76`	`77`	`}`
`77`		`- candidate = null;`
	`78`	`+ deprioritized.add(candidate);`
`78`	`79`	`}`
`79`	`80`
`80`	`81`	`private static boolean isEnabled(final ClusterType clusterType) {`