Skip to content

Commit 78942c1

Browse files
committed
WIP
1 parent 87a1a2e commit 78942c1

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

driver-reactive-streams/src/test/functional/com/mongodb/reactivestreams/client/unified/UnifiedRetryableReadsTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,16 @@
2525
import java.util.Collection;
2626

2727
import static com.mongodb.client.unified.UnifiedRetryableReadsTest.customSkips;
28-
import static org.junit.Assume.assumeFalse;
2928

3029
public class UnifiedRetryableReadsTest extends UnifiedReactiveStreamsTest {
3130
public UnifiedRetryableReadsTest(final String fileDescription, final String testDescription, final String schemaVersion,
3231
final BsonArray runOnRequirements, final BsonArray entitiesArray, final BsonArray initialData, final BsonDocument definition) {
3332
super(schemaVersion, runOnRequirements, entitiesArray, initialData, definition);
3433
customSkips(fileDescription, testDescription);
35-
assumeFalse(testDescription.contains("createChangeStream succeeds after retryable handshake"));
34+
// The reactive driver will execute extra getMore commands for change streams. Ignore them.
35+
if (fileDescription.startsWith("changeStreams") || testDescription.contains("ChangeStream")) {
36+
ignoreExtraEvents();
37+
}
3638
}
3739

3840
@Parameterized.Parameters(name = "{0}: {1}")

driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ public abstract class UnifiedTest {
109109
private final UnifiedClientEncryptionHelper clientEncryptionHelper = new UnifiedClientEncryptionHelper(entities);
110110
private final List<FailPoint> failPoints = new ArrayList<>();
111111
private final UnifiedTestContext rootContext = new UnifiedTestContext();
112+
private boolean ignoreExtraEvents;
112113
private BsonDocument startingClusterTime;
113114

114115
private class UnifiedTestContext {
@@ -151,6 +152,10 @@ public UnifiedTest(@Nullable final String fileDescription, final String schemaVe
151152
crudHelper = new UnifiedCrudHelper(entities, definition.getString("description").getValue());
152153
}
153154

155+
protected void ignoreExtraEvents() {
156+
ignoreExtraEvents = true;
157+
}
158+
154159
public Entities getEntities() {
155160
return entities;
156161
}
@@ -277,7 +282,8 @@ private void compareEvents(final UnifiedTestContext context, final BsonDocument
277282
for (BsonValue cur : definition.getArray("expectEvents")) {
278283
BsonDocument curClientEvents = cur.asDocument();
279284
String client = curClientEvents.getString("client").getValue();
280-
boolean ignoreExtraEvents = curClientEvents.getBoolean("ignoreExtraEvents", BsonBoolean.FALSE).getValue();
285+
boolean ignoreExtraEvents =
286+
curClientEvents.getBoolean("ignoreExtraEvents", BsonBoolean.valueOf(this.ignoreExtraEvents)).getValue();
281287
String eventType = curClientEvents.getString("eventType", new BsonString("command")).getValue();
282288
BsonArray expectedEvents = curClientEvents.getArray("events");
283289
if (eventType.equals("command")) {

0 commit comments

Comments
 (0)