Fix most of the build warnings #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb@01aff5a Many of them were then fixed in mongodb@cd297a1 This commit fixes most of the ones that are still present
stIncMale
commented
Aug 9, 2024
| @@ -68,7 +68,7 @@ class OperationUnitSpecification extends Specification { | |||
| [9, 0]: 25, | |||
| ] | |||
|
|
|||
| static int getMaxWireVersionForServerVersion(List<Integer> serverVersion) { | |||
| static Integer getMaxWireVersionForServerVersion(List<Integer> serverVersion) { | |||
There was a problem hiding this comment.
I don't understand the warning we had for this method, but the change removed that warning. I don't want to spend more time on investigating the weirdness of Groovy.
vbabanin
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commit introduced many warnings 01aff5a. Many of them were then fixed in cd297a1. This PR fixes most of the ones that are still present.