PHP-1510: Fix assertions from write methods return values

Now that unacknowledged writes are routed through legacy opcodes, these write methods return true (as documented).

It appears that the false assertion was due to mongo_convert_write_api_return_to_legacy_retval() converting the response from an unacknowledged write command (likely an empty array) to a boolean.

Author: jmikola

tests/standalone/bug01085-001.phpt

@@ -8,14 +8,14 @@ Test for PHP-1085: w=0 returns unexpected exception on failure (socketTimeoutMS
 
 require_once "tests/utils/server.inc";
 
-function assertFalse($value) {
+function assertTrue($value) {
     if ( ! is_bool($value)) {
         printf("Expected boolean type but received %s\n", gettype($value));
         return;
     }
 
-    if ($value !== false) {
-        echo "Expected boolean false but received boolean true\n";
+    if ($value !== true) {
+        echo "Expected boolean true but received boolean false\n";
     }
 }
 
@@ -34,7 +34,7 @@ for ($i = 0; $i < 10; ++$i) {
         array('x' => $i, 'y' => str_repeat('a', 4*1024*1024)),
         array('w' => 0)
     );
-    assertFalse($retval);
+    assertTrue($retval);
 }
 
 echo "Testing update() with w=0\n";
@@ -44,15 +44,15 @@ $retval = $collection->update(
     array('$set' => array('y' => 1)),
     array('w' => 0)
 );
-assertFalse($retval);
+assertTrue($retval);
 
 echo "Testing remove() with w=0\n";
 
 $retval = $collection->remove(
     array('$where' => 'sleep(1) && false'),
     array('w' => 0)
 );
-assertFalse($retval);
+assertTrue($retval);
 
 echo "Testing update() with w=1\n";
 

tests/standalone/bug01085-002.phpt

@@ -8,14 +8,14 @@ Test for PHP-1085: w=0 returns unexpected exception on failure (socketTimeoutMS
 
 require_once "tests/utils/server.inc";
 
-function assertFalse($value) {
+function assertTrue($value) {
     if ( ! is_bool($value)) {
         printf("Expected boolean type but received %s\n", gettype($value));
         return;
     }
 
-    if ($value !== false) {
-        echo "Expected boolean false but received boolean true\n";
+    if ($value !== true) {
+        echo "Expected boolean true but received boolean false\n";
     }
 }
 
@@ -32,7 +32,7 @@ for ($i = 0; $i < 10; ++$i) {
         array('x' => $i, 'y' => str_repeat('a', 4*1024*1024)),
         array('w' => 0, 'socketTimeoutMS' => 1)
     );
-    assertFalse($retval);
+    assertTrue($retval);
 }
 
 echo "Testing update() with w=0\n";
@@ -42,15 +42,15 @@ $retval = $collection->update(
     array('$set' => array('y' => 1)),
     array('w' => 0, 'socketTimeoutMS' => 1)
 );
-assertFalse($retval);
+assertTrue($retval);
 
 echo "Testing remove() with w=0\n";
 
 $retval = $collection->remove(
     array('$where' => 'sleep(1) && false'),
     array('w' => 0, 'socketTimeoutMS' => 1)
 );
-assertFalse($retval);
+assertTrue($retval);
 
 echo "Testing update() with w=1\n";