Skip to content

Commit 05b55cc

Browse files
committed
PHPC-606: Use mongoc_server_description_host()
1 parent e7e65cc commit 05b55cc

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

php_phongo.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1277,13 +1277,14 @@ void php_phongo_objectid_new_from_oid(zval *object, const bson_oid_t *oid TSRMLS
12771277

12781278
void php_phongo_server_to_zval(zval *retval, mongoc_server_description_t *sd) /* {{{ */
12791279
{
1280-
const bson_t *is_master = mongoc_server_description_ismaster(sd);
1281-
bson_iter_t iter;
1280+
mongoc_host_list_t *host = mongoc_server_description_host(sd);
1281+
const bson_t *is_master = mongoc_server_description_ismaster(sd);
1282+
bson_iter_t iter;
12821283

12831284
array_init(retval);
12841285

1285-
ADD_ASSOC_STRING(retval, "host", (char *)sd->host.host);
1286-
ADD_ASSOC_LONG_EX(retval, "port", sd->host.port);
1286+
ADD_ASSOC_STRING(retval, "host", host->host);
1287+
ADD_ASSOC_LONG_EX(retval, "port", host->port);
12871288
ADD_ASSOC_LONG_EX(retval, "type", sd->type);
12881289
ADD_ASSOC_BOOL_EX(retval, "is_primary", sd->type == MONGOC_SERVER_RS_PRIMARY);
12891290
ADD_ASSOC_BOOL_EX(retval, "is_secondary", sd->type == MONGOC_SERVER_RS_SECONDARY);

src/MongoDB/Server.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ PHP_METHOD(Server, getHost)
146146
}
147147

148148
if ((sd = mongoc_client_get_server_description(intern->client, intern->server_id))) {
149-
PHONGO_RETVAL_STRING(sd->host.host);
149+
PHONGO_RETVAL_STRING(mongoc_server_description_host(sd)->host);
150150
mongoc_server_description_destroy(sd);
151151
return;
152152
}
@@ -277,7 +277,7 @@ PHP_METHOD(Server, getPort)
277277
}
278278

279279
if ((sd = mongoc_client_get_server_description(intern->client, intern->server_id))) {
280-
RETVAL_LONG(sd->host.port);
280+
RETVAL_LONG(mongoc_server_description_host(sd)->port);
281281
mongoc_server_description_destroy(sd);
282282
return;
283283
}
@@ -525,7 +525,7 @@ static int php_phongo_server_compare_objects(zval *o1, zval *o2 TSRMLS_DC) /* {{
525525
sd2 = mongoc_client_get_server_description(intern2->client, intern2->server_id);
526526

527527
if (sd1 && sd2) {
528-
retval = strcasecmp(sd1->host.host_and_port, sd2->host.host_and_port);
528+
retval = strcasecmp(mongoc_server_description_host(sd1)->host_and_port, mongoc_server_description_host(sd2)->host_and_port);
529529
} else {
530530
phongo_throw_exception(PHONGO_ERROR_RUNTIME TSRMLS_CC, "Failed to get server description(s)");
531531
}

0 commit comments

Comments
 (0)