PHPC-347: bson_to_zval() leaks when buffer contains no documents

Author: jmikola

src/bson.c

@@ -898,6 +898,7 @@ int bson_to_zval(const unsigned char *data, int data_len, php_phongo_bson_state
 
 	if (!(b = bson_reader_read(reader, NULL))) {
 		phongo_throw_exception(PHONGO_ERROR_UNEXPECTED_VALUE TSRMLS_CC, "Could not read document from BSON reader");
+		bson_reader_destroy(reader);
 		return 0;
 	}
 

tests/bson/bug0347.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Test for PHPC-347: Memory leak decoding empty buffer
+--SKIPIF--
+<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
+--FILE--
+<?php
+require_once __DIR__ . "/../utils/basic.inc";
+
+try {
+    var_dump(toPHP(''));
+} catch (MongoDB\Driver\Exception\UnexpectedValueException $e) {
+    echo $e->getMessage(), "\n";
+}
+
+?>
+===DONE===
+<?php exit(0); ?>
+--EXPECTF--
+Could not read document from BSON reader
+===DONE===