Skip to content

Commit 3a54c35

Browse files
committed
Remove make target for generating release notes from Git logs
1 parent 93eafac commit 3a54c35

File tree

8 files changed

+13
-4235
lines changed

8 files changed

+13
-4235
lines changed

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,7 @@ failed.txt
6262

6363
# Release files
6464
!bin/*.php
65-
ChangeLog
6665
package.xml
67-
phongo-*tgz
6866
mongodb-*tgz
6967

7068
# Composer (for testing)

CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,12 @@ you must rebuild the extension after updating `php_phongo.h`.
142142

143143
### Publish PECL package
144144

145-
Create the PECL package with `make package`. This should generate a `Changelog`
146-
file, which Git ignores, and add its contents to relevant `RELEASE-X.Y` file.
147-
Additionally, the `package.xml` file will be created from a template and a
148-
`mongodb-X.Y.Z.tgz` package file will be created.
145+
Create the PECL package description file with `make package.xml`. This creates
146+
a `package.xml` file from a template. Version, author, and file information will
147+
be filled in, but release notes must be copied manually from JIRA.
149148

150-
Ensure that the generated PECL package can be successfully installed:
149+
After copying release notes, use `make package` to create the package file (e.g.
150+
`mongodb-X.Y.Z.tgz`) and ensure that it can be successfully installed:
151151

152152
```
153153
$ pecl install -f mongodb-X.Y.Z.tgz
@@ -159,10 +159,10 @@ one chance to confirm the package information after uploading.
159159

160160
### Commit version update and release notes
161161

162-
Commit the modified `php_phongo.h` and `RELEASE-X.Y` files as "Package X.Y.Z"
162+
Commit the modified `php_phongo.h` file as "Package X.Y.Z"
163163

164164
```
165-
$ git add php_phongo.h RELEASE-X.Y
165+
$ git add php_phongo.h
166166
$ git commit -m "Package X.Y.Z"
167167
```
168168

Makefile.frag

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.PHONY: coverage testclean ChangeLog RELEASE package package.xml docs
1+
.PHONY: coverage testclean package package.xml docs
22

33
DATE=`date +%Y-%m-%d--%H-%M-%S`
44
MONGODB_VERSION=$(shell php -n -dextension=modules/mongodb.so -r 'echo MONGODB_VERSION;')
@@ -29,11 +29,10 @@ help:
2929
@echo ""
3030
@echo -e "\t$$ make distcheck"
3131
@echo -e "\t - Builds the archive, runs the virtual tests"
32-
@echo ""
33-
@echo -e "\t$$ make release"
34-
@echo -e "\t - Packages the archive, runs the tests locally and virtual"
3532

3633
@echo ""
34+
@echo -e "\t$$ make package.xml"
35+
@echo -e "\t - Creates a package.xml file with empty release notes"
3736
@echo -e "\t$$ make package"
3837
@echo -e "\t - Creates the pecl archive to use for provisioning"
3938
@echo -e "\t$$ make test-virtual"
@@ -112,44 +111,19 @@ testunit: composer
112111

113112
testall: composer test testunit
114113

115-
116114
testclean:
117115
@for group in generic standalone; do \
118116
find $(top_srcdir)/tests/$$group -type f -name "*.diff" -o -name "*.exp" -o -name "*.log" -o -name "*.mem" -o -name "*.out" -o -name "*.php" -o -name "*.sh" | xargs rm -f; \
119117
done;
120118

121-
mongodbdep:
122-
123-
release: test distcheck
124-
@echo "Please run:"
125-
@echo " " git add RELEASE-$(MONGODB_VERSION)
126-
@echo " " git commit -m \"Add $(MONGODB_VERSION) release notes\"
127-
@echo " " git tag -a -m \"Release $(MONGODB_VERSION)\" $(MONGODB_VERSION)
128-
@echo " " git push --tags
129-
@echo " " make release-docs
130-
@echo "And don't forget to bump version in php_phongo.h"
131-
132-
package: ChangeLog package.xml
133-
@git checkout RELEASE-$(MONGODB_MINOR)
119+
package:
134120
pecl package package.xml
135-
@cat RELEASE-$(MONGODB_MINOR) >> RELEASE-$(MONGODB_VERSION)
136-
@mv RELEASE-$(MONGODB_VERSION) RELEASE-$(MONGODB_MINOR)
137121

138122
docs:
139123
mkdocs build --clean
140124

141125
release-docs: docs
142126
mkdocs gh-deploy --clean
143127

144-
package.xml: RELEASE
128+
package.xml:
145129
php bin/prep-release.php $(MONGODB_VERSION) $(MONGODB_STABILITY)
146-
147-
RELEASE:
148-
@echo "RELEASE $(MONGODB_VERSION)" >> RELEASE-$(MONGODB_VERSION)
149-
@echo "-------------" >> RELEASE-$(MONGODB_VERSION)
150-
@git log --pretty=format:"%ad %an <%ae>%n%x09* %s%n" --no-merges --date short --since="$$(git show -s --format=%ad `git rev-list --tags --max-count=1`)" >> RELEASE-$(MONGODB_VERSION)
151-
@echo -e "\n" >> RELEASE-$(MONGODB_VERSION)
152-
153-
ChangeLog:
154-
@git log --pretty=format:"%ad %an <%ae>%n%x09* %s%n" --date short > ChangeLog
155-

0 commit comments

Comments
 (0)