Add workflow to check formatting

Author: alcaeus

.github/workflows/clang-format.yml

@@ -0,0 +1,40 @@
+name: "Coding Standards"
+
+on:
+  pull_request:
+    branches:
+      - "v*.*"
+      - "master"
+  push:
+    branches:
+      - "v*.*"
+      - "master"
+
+jobs:
+  coding-standards:
+    name: "Coding Standards"
+    runs-on: "ubuntu-20.04"
+
+    strategy:
+      matrix:
+        php-version:
+          - "7.4"
+
+    steps:
+      - name: "Checkout"
+        uses: "actions/checkout@v2"
+        with:
+          submodules: true
+
+      - name: "Install PHP"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          php-version: "${{ matrix.php-version }}"
+          extensions: ":mongodb"
+          tools: "phpize"
+
+      - name: "Configure driver"
+        run: .github/workflows/configure.sh
+
+      - name: "Run clang-format"
+        run: "make format-check"

Makefile.frag

@@ -1,4 +1,4 @@
-.PHONY: coverage test-clean package package.xml format format-changed
+.PHONY: coverage test-clean package package.xml format format-changed format-check
 
 DATE=`date +%Y-%m-%d--%H-%M-%S`
 MONGODB_VERSION=$(shell php -n -dextension=modules/mongodb.so -r 'echo MONGODB_VERSION;')
@@ -70,6 +70,9 @@ format:
 format-changed:
 	$(top_srcdir)/scripts/clang-format.sh changed
 
+format-check:
+	$(top_srcdir)/scripts/clang-format.sh check
+
 distcheck: package test-virtual
 
 test-virtual: package

scripts/clang-format.sh

@@ -1,15 +1,19 @@
 #!/bin/sh
 
-if test x"$1" = x; then 
+CLANG_ARGS="-Werror"
+
+if test x"$1" = xchanged; then
+  FILES1=`git ls-files | grep -v "src/contrib" | grep '\.[ch]$'`
+  FILES2=`git ls-files --others --exclude-standard | grep -v "src/contrib" | grep '\.[ch]$'`
+  FILES="$FILES1 $FILES2"
+else
 	FILES1=`git ls-files | grep -v "src/contrib" | grep '\.[ch]$'`
 	FILES2=`git ls-files --others --exclude-standard | grep -v "src/contrib" | grep '\.[ch]$'`
 	FILES="$FILES1 $FILES2"
 fi
-if test x"$1" = xchanged; then 
-	FILES1=`git diff --name-only | grep -v "src/contrib" | grep '\.[ch]$'`
-	FILES2=`git diff --cached --name-only | grep -v "src/contrib" | grep '\.[ch]$'`
-	FILES3=`git ls-files --others --exclude-standard | grep '\.[ch]$'`
-	FILES="$FILES1 $FILES2 $FILES3"
+
+if test x"$1" = xcheck; then
+	CLANG_ARGS="$CLANG_ARGS -n"
 fi
 
 # Find clang-format, we prefer -6.0, but also allow binaries without -suffix as
@@ -33,7 +37,16 @@ if [ $VERSION_MAJOR -lt 6 ]; then
 	exit
 fi
 
+FAILURE=""
+
 # Run formatter
 for i in $FILES; do
-	$CLANG_FORMAT -i $i
+	$CLANG_FORMAT $CLANG_ARGS -i $i
+	[ $? -eq 0 ] || FAILURE="yes"
 done
+
+if [ -z "$FAILURE" ]; then
+  exit 0
+fi
+
+exit 1