Skip to content

Commit 7eaaa52

Browse files
committed
PHPC-1933: Return type arginfo for Countable and Iterator methods
1 parent 6d093ec commit 7eaaa52

File tree

2 files changed

+28
-10
lines changed

2 files changed

+28
-10
lines changed

src/MongoDB/BulkWrite.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -531,10 +531,14 @@ static PHP_METHOD(BulkWrite, count)
531531
} /* }}} */
532532

533533
/* {{{ MongoDB\Driver\BulkWrite function entries */
534+
/* clang-format off */
534535
ZEND_BEGIN_ARG_INFO_EX(ai_BulkWrite___construct, 0, 0, 0)
535536
ZEND_ARG_ARRAY_INFO(0, options, 1)
536537
ZEND_END_ARG_INFO()
537538

539+
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(ai_BulkWrite_count, 0, 0, IS_LONG, 0)
540+
ZEND_END_ARG_INFO()
541+
538542
ZEND_BEGIN_ARG_INFO_EX(ai_BulkWrite_insert, 0, 0, 1)
539543
ZEND_ARG_INFO(0, document)
540544
ZEND_END_ARG_INFO()
@@ -554,16 +558,15 @@ ZEND_BEGIN_ARG_INFO_EX(ai_BulkWrite_void, 0, 0, 0)
554558
ZEND_END_ARG_INFO()
555559

556560
static zend_function_entry php_phongo_bulkwrite_me[] = {
557-
/* clang-format off */
558561
PHP_ME(BulkWrite, __construct, ai_BulkWrite___construct, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
559562
PHP_ME(BulkWrite, insert, ai_BulkWrite_insert, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
560563
PHP_ME(BulkWrite, update, ai_BulkWrite_update, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
561564
PHP_ME(BulkWrite, delete, ai_BulkWrite_delete, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
562-
PHP_ME(BulkWrite, count, ai_BulkWrite_void, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
565+
PHP_ME(BulkWrite, count, ai_BulkWrite_count, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
563566
ZEND_NAMED_ME(__wakeup, PHP_FN(MongoDB_disabled___wakeup), ai_BulkWrite_void, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
564567
PHP_FE_END
565-
/* clang-format on */
566568
};
569+
/* clang-format on */
567570
/* }}} */
568571

569572
/* {{{ MongoDB\Driver\BulkWrite object handlers */

src/MongoDB/Cursor.c

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,22 @@ PHP_METHOD(Cursor, rewind)
351351
}
352352

353353
/* {{{ MongoDB\Driver\Cursor function entries */
354+
/* clang-format off */
355+
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(ai_Cursor_current, 0, 0, IS_MIXED, 0)
356+
ZEND_END_ARG_INFO()
357+
358+
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(ai_Cursor_key, 0, 0, IS_LONG, 0)
359+
ZEND_END_ARG_INFO()
360+
361+
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(ai_Cursor_next, 0, 0, IS_VOID, 0)
362+
ZEND_END_ARG_INFO()
363+
364+
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(ai_Cursor_valid, 0, 0, _IS_BOOL, 0)
365+
ZEND_END_ARG_INFO()
366+
367+
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(ai_Cursor_rewind, 0, 0, IS_VOID, 0)
368+
ZEND_END_ARG_INFO()
369+
354370
ZEND_BEGIN_ARG_INFO_EX(ai_Cursor_setTypeMap, 0, 0, 1)
355371
ZEND_ARG_ARRAY_INFO(0, typemap, 0)
356372
ZEND_END_ARG_INFO()
@@ -359,24 +375,23 @@ ZEND_BEGIN_ARG_INFO_EX(ai_Cursor_void, 0, 0, 0)
359375
ZEND_END_ARG_INFO()
360376

361377
static zend_function_entry php_phongo_cursor_me[] = {
362-
/* clang-format off */
363378
PHP_ME(Cursor, setTypeMap, ai_Cursor_setTypeMap, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
364379
PHP_ME(Cursor, toArray, ai_Cursor_void, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
365380
PHP_ME(Cursor, getId, ai_Cursor_void, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
366381
PHP_ME(Cursor, getServer, ai_Cursor_void, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
367382
PHP_ME(Cursor, isDead, ai_Cursor_void, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
368383

369-
PHP_ME(Cursor, current, ai_Cursor_void, ZEND_ACC_PUBLIC)
370-
PHP_ME(Cursor, key, ai_Cursor_void, ZEND_ACC_PUBLIC)
371-
PHP_ME(Cursor, next, ai_Cursor_void, ZEND_ACC_PUBLIC)
372-
PHP_ME(Cursor, valid, ai_Cursor_void, ZEND_ACC_PUBLIC)
373-
PHP_ME(Cursor, rewind, ai_Cursor_void, ZEND_ACC_PUBLIC)
384+
PHP_ME(Cursor, current, ai_Cursor_current, ZEND_ACC_PUBLIC)
385+
PHP_ME(Cursor, key, ai_Cursor_key, ZEND_ACC_PUBLIC)
386+
PHP_ME(Cursor, next, ai_Cursor_next, ZEND_ACC_PUBLIC)
387+
PHP_ME(Cursor, valid, ai_Cursor_valid, ZEND_ACC_PUBLIC)
388+
PHP_ME(Cursor, rewind, ai_Cursor_rewind, ZEND_ACC_PUBLIC)
374389

375390
ZEND_NAMED_ME(__construct, PHP_FN(MongoDB_disabled___construct), ai_Cursor_void, ZEND_ACC_PRIVATE | ZEND_ACC_FINAL)
376391
ZEND_NAMED_ME(__wakeup, PHP_FN(MongoDB_disabled___wakeup), ai_Cursor_void, ZEND_ACC_PUBLIC | ZEND_ACC_FINAL)
377392
PHP_FE_END
378-
/* clang-format on */
379393
};
394+
/* clang-format on */
380395
/* }}} */
381396

382397
/* {{{ MongoDB\Driver\Cursor object handlers */

0 commit comments

Comments
 (0)