PHPC-1934: Check for uninitialized intern in ServerDescription get_properties_hash (#1247)

tanlisu · jmikola · commit 813d7b8518e2 · 2021-08-17T10:15:18.000-04:00
diff --git a/src/MongoDB/ServerDescription.c b/src/MongoDB/ServerDescription.c
@@ -178,6 +178,10 @@ HashTable* php_phongo_serverdescription_get_properties_hash(phongo_compat_object
 
 	PHONGO_GET_PROPERTY_HASH_INIT_PROPS(is_debug, intern, props, 6);
 
+	if (!intern->server_description) {
+		return props;
+	}
+
 	{
 		zval                host, port, type;
 		mongoc_host_list_t* host_list = mongoc_server_description_host(intern->server_description);

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,10 @@ HashTable* php_phongo_serverdescription_get_properties_hash(phongo_compat_object`
`178`	`178`
`179`	`179`	`PHONGO_GET_PROPERTY_HASH_INIT_PROPS(is_debug, intern, props, 6);`
`180`	`180`
	`181`	`+ if (!intern->server_description) {`
	`182`	`+ return props;`
	`183`	`+ }`
	`184`	`+`
`181`	`185`	`{`
`182`	`186`	`zval host, port, type;`
`183`	`187`	`mongoc_host_list_t* host_list = mongoc_server_description_host(intern->server_description);`