Skip to content

Commit 9090d84

Browse files
committed
Apply feedback from code review
1 parent 51cdb21 commit 9090d84

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

bin/prep-release.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function get_files() {
4949

5050
"src/libmongoc/src/common/src/*.{c,h,h.in}",
5151
// Note: src/libmongoc/src/common/src/mlib/ does not contain source files (as of libmongoc 2.0.1)
52-
"src/libmongoc/src/common/src/mlib/*.{c,h}",
52+
"src/libmongoc/src/common/src/mlib/*.h",
5353
"src/libmongoc/src/kms-message/src/*.{c,h}",
5454
"src/libmongoc/src/kms-message/src/kms_message/*.{c,h}",
5555
"src/libmongoc/src/libbson/src/bson/*.{c,h,h.in}",
@@ -65,7 +65,7 @@ function get_files() {
6565
"src/libmongocrypt-compat/mongocrypt/*.{c,h}",
6666
"src/libmongocrypt/src/*.{c,h,h.in}",
6767
"src/libmongocrypt/src/crypto/*.{c,h}",
68-
"src/libmongocrypt/src/mlib/*.{c,h}",
68+
"src/libmongocrypt/src/mlib/*.h",
6969
// Note: src/libmongocrypt/src/mlib/ does not contain source files (as of libmongocrypt 1.14.0)
7070
"src/libmongocrypt/src/mlib/*.h",
7171
"src/libmongocrypt/src/os_posix/*.{c,h}",

tests/manager/manager-ctor-write_concern-error-001.phpt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ echo throws(function() {
1212
create_test_manager(null, ['w' => 1.0]);
1313
}, "MongoDB\Driver\Exception\InvalidArgumentException"), "\n";
1414

15-
/* Note: Values of w < 0 are invalid, but libmongoc's URI string parsing only
16-
* logs a warning instead of raising an error (see: CDRIVER-2234), so we cannot
17-
* test for this. */
18-
1915
echo throws(function() {
2016
create_test_manager(null, ['w' => -1]);
2117
}, "MongoDB\Driver\Exception\InvalidArgumentException"), "\n";

0 commit comments

Comments
 (0)