PHPC-1791: Specify correct return type in __set_state protos (#1228)

tanlisu · web-flow · commit bcd1a492251d · 2021-06-22T10:11:11.000-04:00
diff --git a/src/BSON/Binary.c b/src/BSON/Binary.c
@@ -91,7 +91,7 @@ static PHP_METHOD(Binary, __construct)
 	php_phongo_binary_init(intern, data, data_len, type);
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\Binary::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\Binary MongoDB\BSON\Binary::__set_state(array $properties)
 */
 static PHP_METHOD(Binary, __set_state)
 {
diff --git a/src/BSON/Decimal128.c b/src/BSON/Decimal128.c
@@ -77,7 +77,7 @@ static PHP_METHOD(Decimal128, __construct)
 	php_phongo_decimal128_init(intern, value);
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\Decimal128::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\Decimal128 MongoDB\BSON\Decimal128::__set_state(array $properties)
 */
 static PHP_METHOD(Decimal128, __set_state)
 {
diff --git a/src/BSON/Javascript.c b/src/BSON/Javascript.c
@@ -96,7 +96,7 @@ static PHP_METHOD(Javascript, __construct)
 	php_phongo_javascript_init(intern, code, code_len, scope);
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\Javascript::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\Javascript MongoDB\BSON\Javascript::__set_state(array $properties)
 */
 static PHP_METHOD(Javascript, __set_state)
 {
diff --git a/src/BSON/MaxKey.c b/src/BSON/MaxKey.c
@@ -28,7 +28,7 @@
 
 zend_class_entry* php_phongo_maxkey_ce;
 
-/* {{{ proto void MongoDB\BSON\MaxKey::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\MaxKey MongoDB\BSON\MaxKey::__set_state(array $properties)
 */
 static PHP_METHOD(MaxKey, __set_state)
 {
diff --git a/src/BSON/MinKey.c b/src/BSON/MinKey.c
@@ -28,7 +28,7 @@
 
 zend_class_entry* php_phongo_minkey_ce;
 
-/* {{{ proto void MongoDB\BSON\MinKey::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\MinKey MongoDB\BSON\MinKey::__set_state(array $properties)
 */
 static PHP_METHOD(MinKey, __set_state)
 {
diff --git a/src/BSON/ObjectId.c b/src/BSON/ObjectId.c
@@ -126,7 +126,7 @@ static PHP_METHOD(ObjectId, getTimestamp)
 	RETVAL_LONG(bson_oid_get_time_t(&tmp_oid));
 } /* }}} */
 
-/* {{{ proto MongoDB\BSON\ObjectId::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\ObjectId MongoDB\BSON\ObjectId::__set_state(array $properties)
 */
 static PHP_METHOD(ObjectId, __set_state)
 {
diff --git a/src/BSON/Regex.c b/src/BSON/Regex.c
@@ -143,7 +143,7 @@ static PHP_METHOD(Regex, getFlags)
 	RETURN_STRINGL(intern->flags, intern->flags_len);
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\Regex::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\Regex MongoDB\BSON\Regex::__set_state(array $properties)
 */
 static PHP_METHOD(Regex, __set_state)
 {
diff --git a/src/BSON/Timestamp.c b/src/BSON/Timestamp.c
@@ -171,7 +171,7 @@ static PHP_METHOD(Timestamp, getTimestamp)
 	RETVAL_LONG(intern->timestamp);
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\Timestamp::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\Timestamp MongoDB\BSON\Timestamp::__set_state(array $properties)
 */
 static PHP_METHOD(Timestamp, __set_state)
 {
diff --git a/src/BSON/UTCDateTime.c b/src/BSON/UTCDateTime.c
@@ -170,7 +170,7 @@ static PHP_METHOD(UTCDateTime, __construct)
 	php_phongo_utcdatetime_init_from_string(intern, Z_STRVAL_P(milliseconds), Z_STRLEN_P(milliseconds));
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\UTCDateTime::__set_state(array $properties)
+/* {{{ proto MongoDB\BSON\UTCDateTime MongoDB\BSON\UTCDateTime::__set_state(array $properties)
 */
 static PHP_METHOD(UTCDateTime, __set_state)
 {
diff --git a/src/MongoDB/ReadConcern.c b/src/MongoDB/ReadConcern.c
@@ -79,7 +79,7 @@ static PHP_METHOD(ReadConcern, __construct)
 	}
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\ReadConcern::__set_state(array $properties)
+/* {{{ proto MongoDB\Driver\ReadConcern MongoDB\Driver\ReadConcern::__set_state(array $properties)
 */
 static PHP_METHOD(ReadConcern, __set_state)
 {
diff --git a/src/MongoDB/ReadPreference.c b/src/MongoDB/ReadPreference.c
@@ -308,7 +308,7 @@ static PHP_METHOD(ReadPreference, __construct)
 	}
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\ReadPreference::__set_state(array $properties)
+/* {{{ proto MongoDB\Driver\ReadPreference MongoDB\Driver\ReadPreference::__set_state(array $properties)
 */
 static PHP_METHOD(ReadPreference, __set_state)
 {
diff --git a/src/MongoDB/ServerApi.c b/src/MongoDB/ServerApi.c
@@ -123,7 +123,7 @@ static PHP_METHOD(ServerApi, __construct)
 		(bool) deprecation_errors);
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\ServerApi::__set_state(array $properties)
+/* {{{ proto MongoDB\Driver\ServerApi MongoDB\Driver\ServerApi::__set_state(array $properties)
 */
 static PHP_METHOD(ServerApi, __set_state)
 {
diff --git a/src/MongoDB/WriteConcern.c b/src/MongoDB/WriteConcern.c
@@ -169,7 +169,7 @@ static PHP_METHOD(WriteConcern, __construct)
 	}
 } /* }}} */
 
-/* {{{ proto void MongoDB\BSON\WriteConcern::__set_state(array $properties)
+/* {{{ proto MongoDB\Driver\WriteConcern MongoDB\Driver\WriteConcern::__set_state(array $properties)
 */
 static PHP_METHOD(WriteConcern, __set_state)
 {

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ static PHP_METHOD(Binary, __construct)`
`91`	`91`	`php_phongo_binary_init(intern, data, data_len, type);`
`92`	`92`	`} /* }}} */`
`93`	`93`
`94`		`-/* {{{ proto void MongoDB\BSON\Binary::__set_state(array $properties)`
	`94`	`+/* {{{ proto MongoDB\BSON\Binary MongoDB\BSON\Binary::__set_state(array $properties)`
`95`	`95`	`*/`
`96`	`96`	`static PHP_METHOD(Binary, __set_state)`
`97`	`97`	`{`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ static PHP_METHOD(Decimal128, __construct)`
`77`	`77`	`php_phongo_decimal128_init(intern, value);`
`78`	`78`	`} /* }}} */`
`79`	`79`
`80`		`-/* {{{ proto void MongoDB\BSON\Decimal128::__set_state(array $properties)`
	`80`	`+/* {{{ proto MongoDB\BSON\Decimal128 MongoDB\BSON\Decimal128::__set_state(array $properties)`
`81`	`81`	`*/`
`82`	`82`	`static PHP_METHOD(Decimal128, __set_state)`
`83`	`83`	`{`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ static PHP_METHOD(Javascript, __construct)`
`96`	`96`	`php_phongo_javascript_init(intern, code, code_len, scope);`
`97`	`97`	`} /* }}} */`
`98`	`98`
`99`		`-/* {{{ proto void MongoDB\BSON\Javascript::__set_state(array $properties)`
	`99`	`+/* {{{ proto MongoDB\BSON\Javascript MongoDB\BSON\Javascript::__set_state(array $properties)`
`100`	`100`	`*/`
`101`	`101`	`static PHP_METHOD(Javascript, __set_state)`
`102`	`102`	`{`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@`
`28`	`28`
`29`	`29`	`zend_class_entry* php_phongo_maxkey_ce;`
`30`	`30`
`31`		`-/* {{{ proto void MongoDB\BSON\MaxKey::__set_state(array $properties)`
	`31`	`+/* {{{ proto MongoDB\BSON\MaxKey MongoDB\BSON\MaxKey::__set_state(array $properties)`
`32`	`32`	`*/`
`33`	`33`	`static PHP_METHOD(MaxKey, __set_state)`
`34`	`34`	`{`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ static PHP_METHOD(ObjectId, getTimestamp)`
`126`	`126`	`RETVAL_LONG(bson_oid_get_time_t(&tmp_oid));`
`127`	`127`	`} /* }}} */`
`128`	`128`
`129`		`-/* {{{ proto MongoDB\BSON\ObjectId::__set_state(array $properties)`
	`129`	`+/* {{{ proto MongoDB\BSON\ObjectId MongoDB\BSON\ObjectId::__set_state(array $properties)`
`130`	`130`	`*/`
`131`	`131`	`static PHP_METHOD(ObjectId, __set_state)`
`132`	`132`	`{`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ static PHP_METHOD(Regex, getFlags)`
`143`	`143`	`RETURN_STRINGL(intern->flags, intern->flags_len);`
`144`	`144`	`} /* }}} */`
`145`	`145`
`146`		`-/* {{{ proto void MongoDB\BSON\Regex::__set_state(array $properties)`
	`146`	`+/* {{{ proto MongoDB\BSON\Regex MongoDB\BSON\Regex::__set_state(array $properties)`
`147`	`147`	`*/`
`148`	`148`	`static PHP_METHOD(Regex, __set_state)`
`149`	`149`	`{`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ static PHP_METHOD(Timestamp, getTimestamp)`
`171`	`171`	`RETVAL_LONG(intern->timestamp);`
`172`	`172`	`} /* }}} */`
`173`	`173`
`174`		`-/* {{{ proto void MongoDB\BSON\Timestamp::__set_state(array $properties)`
	`174`	`+/* {{{ proto MongoDB\BSON\Timestamp MongoDB\BSON\Timestamp::__set_state(array $properties)`
`175`	`175`	`*/`
`176`	`176`	`static PHP_METHOD(Timestamp, __set_state)`
`177`	`177`	`{`
Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ static PHP_METHOD(UTCDateTime, __construct)`
`170`	`170`	`php_phongo_utcdatetime_init_from_string(intern, Z_STRVAL_P(milliseconds), Z_STRLEN_P(milliseconds));`
`171`	`171`	`} /* }}} */`
`172`	`172`
`173`		`-/* {{{ proto void MongoDB\BSON\UTCDateTime::__set_state(array $properties)`
	`173`	`+/* {{{ proto MongoDB\BSON\UTCDateTime MongoDB\BSON\UTCDateTime::__set_state(array $properties)`
`174`	`174`	`*/`
`175`	`175`	`static PHP_METHOD(UTCDateTime, __set_state)`
`176`	`176`	`{`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ static PHP_METHOD(ReadConcern, __construct)`
`79`	`79`	`}`
`80`	`80`	`} /* }}} */`
`81`	`81`
`82`		`-/* {{{ proto void MongoDB\BSON\ReadConcern::__set_state(array $properties)`
	`82`	`+/* {{{ proto MongoDB\Driver\ReadConcern MongoDB\Driver\ReadConcern::__set_state(array $properties)`
`83`	`83`	`*/`
`84`	`84`	`static PHP_METHOD(ReadConcern, __set_state)`
`85`	`85`	`{`
Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ static PHP_METHOD(ReadPreference, __construct)`
`308`	`308`	`}`
`309`	`309`	`} /* }}} */`
`310`	`310`
`311`		`-/* {{{ proto void MongoDB\BSON\ReadPreference::__set_state(array $properties)`
	`311`	`+/* {{{ proto MongoDB\Driver\ReadPreference MongoDB\Driver\ReadPreference::__set_state(array $properties)`
`312`	`312`	`*/`
`313`	`313`	`static PHP_METHOD(ReadPreference, __set_state)`
`314`	`314`	`{`