Skip to content

Commit d9b6613

Browse files
committed
Remove unnecessary SKIPIFs from ReadPreference tests
1 parent 236e9bd commit d9b6613

6 files changed

+4
-18
lines changed

tests/readPreference/readpreference-ctor-001.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
--TEST--
22
MongoDB\Driver\ReadPreference construction
3-
--SKIPIF--
4-
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
53
--FILE--
64
<?php
7-
require_once __DIR__ . "/../utils/basic.inc";
85

96
var_dump(new MongoDB\Driver\ReadPreference(MongoDB\Driver\ReadPreference::RP_PRIMARY));
107
var_dump(new MongoDB\Driver\ReadPreference(MongoDB\Driver\ReadPreference::RP_SECONDARY, array(array("tag" => "one"))));

tests/readPreference/readpreference-ctor_error-001.phpt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
--TEST--
22
MongoDB\Driver\ReadPreference construction (invalid mode)
3-
--SKIPIF--
4-
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
53
--FILE--
64
<?php
7-
require_once __DIR__ . "/../utils/basic.inc";
5+
6+
require_once __DIR__ . '/../utils/tools.php';
87

98
echo throws(function() {
109
new MongoDB\Driver\ReadPreference(42);

tests/readPreference/readpreference-ctor_error-002.phpt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
--TEST--
22
MongoDB\Driver\ReadPreference construction (invalid tagSets)
3-
--SKIPIF--
4-
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
53
--FILE--
64
<?php
7-
require_once __DIR__ . "/../utils/basic.inc";
5+
6+
require_once __DIR__ . '/../utils/tools.php';
87

98
echo throws(function() {
109
new MongoDB\Driver\ReadPreference(MongoDB\Driver\ReadPreference::RP_PRIMARY, [['tag' => 'one']]);

tests/readPreference/readpreference-getMode-001.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
--TEST--
22
MongoDB\Driver\ReadPreference::getMode()
3-
--SKIPIF--
4-
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
53
--FILE--
64
<?php
7-
require_once __DIR__ . "/../utils/basic.inc";
85

96
$tests = array(
107
MongoDB\Driver\ReadPreference::RP_PRIMARY,

tests/readPreference/readpreference-getTagSets-001.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
--TEST--
22
MongoDB\Driver\ReadPreference::getTagSets()
3-
--SKIPIF--
4-
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
53
--FILE--
64
<?php
7-
require_once __DIR__ . "/../utils/basic.inc";
85

96
$tests = array(
107
null,

tests/readPreference/readpreference_error-001.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
--TEST--
22
MongoDB\Driver\ReadPreference cannot be extended
3-
--SKIPIF--
4-
<?php require __DIR__ . "/../utils/basic-skipif.inc"?>
53
--FILE--
64
<?php
7-
require_once __DIR__ . "/../utils/basic.inc";
85

96
class MyReadPreference extends MongoDB\Driver\ReadPreference {}
107

0 commit comments

Comments
 (0)