Skip to content

Commit dcc2fdf

Browse files
jmikolajmikola
committed
PHPC-1113: Use XFAIL instead of skips for tests to be reimplemented
1 parent 8ca94d0 commit dcc2fdf

20 files changed

+42
-22
lines changed

‎tests/bulk/bulkwrite-update-arrayFilters-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\BulkWrite::update with arrayFilters
3+
--XFAIL--
4+
START() tests must be reimplemented (PHPC-1179)
35
--SKIPIF--
4-
<?php echo "skip START() tests must be reimplemented (PHPC-1179)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php START('THROWAWAY', ["version" => "36-release"]); CLEANUP(THROWAWAY); ?>
78
--FILE--

‎tests/command/findAndModify-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\Command with findAndModify and arrayFilters
3+
--XFAIL--
4+
START() tests must be reimplemented (PHPC-1179)
35
--SKIPIF--
4-
<?php echo "skip START() tests must be reimplemented (PHPC-1179)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php START('THROWAWAY', ["version" => "36-release"]); CLEANUP(THROWAWAY); ?>
78
--FILE--

‎tests/command/update-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\Command with update and arrayFilters
3+
--XFAIL--
4+
START() tests must be reimplemented (PHPC-1179)
35
--SKIPIF--
4-
<?php echo "skip START() tests must be reimplemented (PHPC-1179)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php START('THROWAWAY', ["version" => "36-release"]); CLEANUP(THROWAWAY); ?>
78
--FILE--

‎tests/connect/replicaset-seedlist-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\Manager: Connecting to Replica Set with only secondary in seedlist
3+
--XFAIL--
4+
replica set seedlist tests must be reimplemented (PHPC-1173)
35
--SKIPIF--
4-
<?php echo "skip replica set seedlist tests must be reimplemented (PHPC-1173)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_replica_set(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/connect/replicaset-seedlist-002.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\Manager: Connecting to Replica Set with only arbiter in seedlist
3+
--XFAIL--
4+
replica set seedlist tests must be reimplemented (PHPC-1173)
35
--SKIPIF--
4-
<?php echo "skip replica set seedlist tests must be reimplemented (PHPC-1173)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_replica_set(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/connect/standalone-auth-0002.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
Connect to MongoDB with using default auth mechanism #002
3+
--XFAIL--
4+
parse_url() tests must be reimplemented (PHPC-1177)
35
--SKIPIF--
4-
<?php echo "skip parse_url() tests must be reimplemented (PHPC-1177)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_auth(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/connect/standalone-plain-0001.phpt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
--TEST--
22
Connect to MongoDB with using PLAIN auth mechanism
3+
--XFAIL--
4+
authMechanism=PLAIN (LDAP) tests must be reimplemented (PHPC-1172)
5+
parse_url() tests must be reimplemented (PHPC-1177)
36
--SKIPIF--
4-
<?php echo "skip authMechanism=PLAIN (LDAP) tests must be reimplemented (PHPC-1172)\n"; ?>
5-
<?php echo "skip parse_url() tests must be reimplemented (PHPC-1177)\n"; ?>
67
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
78
<?php skip_if_not_clean(); ?>
89
--FILE--

‎tests/connect/standalone-plain-0002.phpt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
--TEST--
22
Connect to MongoDB with using PLAIN auth mechanism #002
3+
--XFAIL--
4+
authMechanism=PLAIN (LDAP) tests must be reimplemented (PHPC-1172)
5+
parse_url() tests must be reimplemented (PHPC-1177)
36
--SKIPIF--
4-
<?php echo "skip authMechanism=PLAIN (LDAP) tests must be reimplemented (PHPC-1172)\n"; ?>
5-
<?php echo "skip parse_url() tests must be reimplemented (PHPC-1177)\n"; ?>
67
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
78
<?php skip_if_not_libmongoc_ssl(); ?>
89
--FILE--

‎tests/connect/standalone-x509-error-0001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
X509 connection should not reuse previous stream after an auth failure
3+
--XFAIL--
4+
parse_url() tests must be reimplemented (PHPC-1177)
35
--SKIPIF--
4-
<?php echo "skip parse_url() tests must be reimplemented (PHPC-1177)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_libmongoc_ssl(); ?>
78
<?php skip_if_not_ssl(); ?>

‎tests/connect/standalone-x509-extract_username-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
Connect to MongoDB with SSL and X509 auth and username retrieved from cert
3+
--XFAIL--
4+
parse_url() tests must be reimplemented (PHPC-1177)
35
--SKIPIF--
4-
<?php echo "skip parse_url() tests must be reimplemented (PHPC-1177)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_libmongoc_ssl(['OpenSSL', 'Secure Transport', 'Secure Channel']); ?>
78
<?php skip_if_not_ssl(); ?>

‎tests/connect/standalone-x509-extract_username-002.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
Connect to MongoDB with SSL and X509 auth and username retrieved from cert (stream context)
3+
--XFAIL--
4+
parse_url() tests must be reimplemented (PHPC-1177)
35
--SKIPIF--
4-
<?php echo "skip parse_url() tests must be reimplemented (PHPC-1177)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_libmongoc_ssl(['OpenSSL', 'Secure Transport', 'Secure Channel']); ?>
78
<?php skip_if_not_ssl(); ?>

‎tests/cursor/cursor-getmore-005.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\Cursor query result iteration with getmore failure
3+
--XFAIL--
4+
START() tests must be reimplemented (PHPC-1179)
35
--SKIPIF--
4-
<?php echo "skip START() tests must be reimplemented (PHPC-1179)\n"; ?>
56
<?php require __DIR__ . "/" ."../utils/basic-skipif.inc"; ?>
67
<?php START("THROWAWAY", ["version" => "30-release"]); CLEANUP(THROWAWAY); ?>
78
--FILE--

‎tests/cursor/cursor-getmore-006.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\Cursor command result iteration with getmore failure
3+
--XFAIL--
4+
START() tests must be reimplemented (PHPC-1179)
35
--SKIPIF--
4-
<?php echo "skip START() tests must be reimplemented (PHPC-1179)\n"; ?>
56
<?php require __DIR__ . "/" ."../utils/basic-skipif.inc"; ?>
67
<?php START("THROWAWAY", ["version" => "30-release"]); CLEANUP(THROWAWAY); ?>
78
--FILE--

‎tests/functional/cursor-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
Sorting single field, ascending, using the Cursor Iterator
3+
--XFAIL--
4+
LOAD() tests must be reimplemented (PHPC-1178)
35
--SKIPIF--
4-
<?php echo "skip LOAD() tests must be reimplemented (PHPC-1178)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_live(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/functional/cursorid-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
Sorting single field, ascending, using the Cursor Iterator
3+
--XFAIL--
4+
LOAD() tests must be reimplemented (PHPC-1178)
35
--SKIPIF--
4-
<?php echo "skip LOAD() tests must be reimplemented (PHPC-1178)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_live(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/functional/query-sort-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
Sorting single field, ascending
3+
--XFAIL--
4+
LOAD() tests must be reimplemented (PHPC-1178)
35
--SKIPIF--
4-
<?php echo "skip LOAD() tests must be reimplemented (PHPC-1178)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_live(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/functional/query-sort-002.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
Sorting single field, descending
3+
--XFAIL--
4+
LOAD() tests must be reimplemented (PHPC-1178)
35
--SKIPIF--
4-
<?php echo "skip LOAD() tests must be reimplemented (PHPC-1178)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_live(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/functional/query-sort-003.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
Sorting single field, ascending, using the Cursor Iterator
3+
--XFAIL--
4+
LOAD() tests must be reimplemented (PHPC-1178)
35
--SKIPIF--
4-
<?php echo "skip LOAD() tests must be reimplemented (PHPC-1178)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_live(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/manager/manager-set-uri-options-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\Manager: Logging into MongoDB using credentials from $options
3+
--XFAIL--
4+
parse_url() tests must be reimplemented (PHPC-1177)
35
--SKIPIF--
4-
<?php echo "skip parse_url() tests must be reimplemented (PHPC-1177)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_auth(); ?>
78
<?php skip_if_not_clean(); ?>

‎tests/server/server-construct-001.phpt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
--TEST--
22
MongoDB\Driver\Server::__construct()
3+
--XFAIL--
4+
parse_url() tests must be reimplemented (PHPC-1177)
35
--SKIPIF--
4-
<?php echo "skip parse_url() tests must be reimplemented (PHPC-1177)\n"; ?>
56
<?php require __DIR__ . "/../utils/basic-skipif.inc"; ?>
67
<?php skip_if_not_live(); ?>
78
<?php skip_if_not_clean(); ?>

0 commit comments

Comments
 (0)