PHPC-952: Remove obsolete init argument from javascript initializers

Author: alcaeus

src/bson.c

@@ -605,23 +605,21 @@ static bool php_phongo_bson_visit_symbol(const bson_iter_t* iter, const char* ke
 	return false;
 } /* }}} */
 
-static void php_phongo_bson_new_javascript_from_javascript_and_scope(int init, zval* object, const char* code, size_t code_len, const bson_t* scope TSRMLS_DC) /* {{{ */
+static void php_phongo_bson_new_javascript_from_javascript_and_scope(zval* object, const char* code, size_t code_len, const bson_t* scope TSRMLS_DC) /* {{{ */
 {
 	php_phongo_javascript_t* intern;
 
-	if (init) {
-		object_init_ex(object, php_phongo_javascript_ce);
-	}
+	object_init_ex(object, php_phongo_javascript_ce);
 
 	intern           = Z_JAVASCRIPT_OBJ_P(object);
 	intern->code     = estrndup(code, code_len);
 	intern->code_len = code_len;
 	intern->scope    = scope ? bson_copy(scope) : NULL;
 } /* }}} */
 
-static void php_phongo_bson_new_javascript_from_javascript(int init, zval* object, const char* code, size_t code_len TSRMLS_DC) /* {{{ */
+static void php_phongo_bson_new_javascript_from_javascript(zval* object, const char* code, size_t code_len TSRMLS_DC) /* {{{ */
 {
-	php_phongo_bson_new_javascript_from_javascript_and_scope(init, object, code, code_len, NULL TSRMLS_CC);
+	php_phongo_bson_new_javascript_from_javascript_and_scope(object, code, code_len, NULL TSRMLS_CC);
 } /* }}} */
 
 static bool php_phongo_bson_visit_code(const bson_iter_t* iter ARG_UNUSED, const char* key, size_t v_code_len, const char* v_code, void* data) /* {{{ */
@@ -631,7 +629,7 @@ static bool php_phongo_bson_visit_code(const bson_iter_t* iter ARG_UNUSED, const
 #if PHP_VERSION_ID >= 70000
 	zval zchild;
 
-	php_phongo_bson_new_javascript_from_javascript(1, &zchild, v_code, v_code_len TSRMLS_CC);
+	php_phongo_bson_new_javascript_from_javascript(&zchild, v_code, v_code_len TSRMLS_CC);
 
 	if (state->is_visiting_array) {
 		add_next_index_zval(retval, &zchild);
@@ -643,7 +641,7 @@ static bool php_phongo_bson_visit_code(const bson_iter_t* iter ARG_UNUSED, const
 	TSRMLS_FETCH();
 
 	MAKE_STD_ZVAL(zchild);
-	php_phongo_bson_new_javascript_from_javascript(1, zchild, v_code, v_code_len TSRMLS_CC);
+	php_phongo_bson_new_javascript_from_javascript(zchild, v_code, v_code_len TSRMLS_CC);
 
 	if (state->is_visiting_array) {
 		add_next_index_zval(retval, zchild);
@@ -709,7 +707,7 @@ static bool php_phongo_bson_visit_codewscope(const bson_iter_t* iter ARG_UNUSED,
 #if PHP_VERSION_ID >= 70000
 	zval zchild;
 
-	php_phongo_bson_new_javascript_from_javascript_and_scope(1, &zchild, v_code, v_code_len, v_scope TSRMLS_CC);
+	php_phongo_bson_new_javascript_from_javascript_and_scope(&zchild, v_code, v_code_len, v_scope TSRMLS_CC);
 
 	if (state->is_visiting_array) {
 		add_next_index_zval(retval, &zchild);
@@ -721,7 +719,7 @@ static bool php_phongo_bson_visit_codewscope(const bson_iter_t* iter ARG_UNUSED,
 	TSRMLS_FETCH();
 
 	MAKE_STD_ZVAL(zchild);
-	php_phongo_bson_new_javascript_from_javascript_and_scope(1, zchild, v_code, v_code_len, v_scope TSRMLS_CC);
+	php_phongo_bson_new_javascript_from_javascript_and_scope(zchild, v_code, v_code_len, v_scope TSRMLS_CC);
 
 	if (state->is_visiting_array) {
 		add_next_index_zval(retval, zchild);