Fixed CID-60852: Pointer to local outside scope

bjori · bjori · commit f4fd18891093 · 2014-11-24T11:29:02.000-08:00
Pointer to local outside scope:
`key` points to an out-of-scope variable `numbuf` :]
diff --git a/src/bson.c b/src/bson.c
@@ -750,6 +750,7 @@ PHONGO_API void zval_to_bson(zval *data, phongo_bson_flags_t flags, bson_t *bson
 	for (;; zend_hash_move_forward_ex(ht_data, &pos)) {
 		unsigned int key_len = 0;
 		uint64_t     index = 0;
+		char         numbuf[32];
 		char        *key = NULL;
 		zval       **entry;
 		int          hash_type = HASH_KEY_NON_EXISTENT;
@@ -781,8 +782,6 @@ PHONGO_API void zval_to_bson(zval *data, phongo_bson_flags_t flags, bson_t *bson
 				}
 			}
 		} else {
-			char numbuf[32];
-
 			key_len = bson_uint32_to_string(index, (const char **)&key, numbuf, sizeof(numbuf));
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -750,6 +750,7 @@ PHONGO_API void zval_to_bson(zval data, phongo_bson_flags_t flags, bson_t bson`
`750`	`750`	`for (;; zend_hash_move_forward_ex(ht_data, &pos)) {`
`751`	`751`	`unsigned int key_len = 0;`
`752`	`752`	`uint64_t index = 0;`
	`753`	`+ char numbuf[32];`
`753`	`754`	`char *key = NULL;`
`754`	`755`	`zval **entry;`
`755`	`756`	`int hash_type = HASH_KEY_NON_EXISTENT;`
`@@ -781,8 +782,6 @@ PHONGO_API void zval_to_bson(zval data, phongo_bson_flags_t flags, bson_t bson`
`781`	`782`	`}`
`782`	`783`	`}`
`783`	`784`	`} else {`
`784`		`- char numbuf[32];`
`785`		`-`
`786`	`785`	`key_len = bson_uint32_to_string(index, (const char **)&key, numbuf, sizeof(numbuf));`
`787`	`786`	`}`
`788`	`787`