Fixes for coding standards and static analysis

Author: jmikola

examples/changestream.php

@@ -7,12 +7,14 @@
 
 use MongoDB\Client;
 
+use function assert;
 use function fprintf;
 use function getenv;
-use function hrtime;
+use function is_object;
 use function MongoDB\BSON\fromPHP;
 use function MongoDB\BSON\toRelaxedExtendedJSON;
 use function printf;
+use function time;
 
 use const STDERR;
 
@@ -21,7 +23,7 @@ function toJSON(object $document): string
     return toRelaxedExtendedJSON(fromPHP($document));
 }
 
-$client = new Client(getenv('MONGODB_URI') ?? null);
+$client = new Client(getenv('MONGODB_URI') ?: 'mongodb://127.0.0.1/');
 
 $collection = $client->test->coll;
 $collection->drop();
@@ -38,16 +40,18 @@ function toJSON(object $document): string
 
 $changeStream->rewind();
 
-$startTime = hrtime(true);
+$startTime = time();
 
 while (true) {
     if ($changeStream->valid()) {
-        printf("%s\n", toJSON($changeStream->current()));
+        $event = $changeStream->current();
+        assert(is_object($event));
+        printf("%s\n", toJSON($event));
     }
 
     $changeStream->next();
 
-    if (hrtime(true) - $startTime > 5e+9) {
+    if (time() - $startTime > 5e+9) {
         fprintf(STDERR, "Aborting after 5 seconds...\n");
         break;
     }

examples/command_logger.php

@@ -1,8 +1,6 @@
 <?php
 declare(strict_types=1);
 
-// phpcs:disable Squiz.Classes.ClassFileName.NoMatch
-
 namespace MongoDB\Examples;
 
 require '../vendor/autoload.php';
@@ -13,9 +11,11 @@
 use MongoDB\Driver\Monitoring\CommandSubscriber;
 use MongoDB\Driver\Monitoring\CommandSucceededEvent;
 
+use function assert;
 use function fprintf;
 use function get_class;
 use function getenv;
+use function is_object;
 use function MongoDB\BSON\fromPHP;
 use function MongoDB\BSON\toRelaxedExtendedJSON;
 use function printf;
@@ -27,6 +27,7 @@ function toJSON(object $document): string
     return toRelaxedExtendedJSON(fromPHP($document));
 }
 
+// phpcs:disable Squiz.Classes.ClassFileName.NoMatch
 class CommandLogger implements CommandSubscriber
 {
     public function commandStarted(CommandStartedEvent $event): void
@@ -56,9 +57,8 @@ public function commandFailed(CommandFailedEvent $event): void
         fprintf(STDERR, "\n");
     }
 }
-// phpcs:enable
 
-$client = new Client(getenv('MONGODB_URI') ?? null);
+$client = new Client(getenv('MONGODB_URI') ?: 'mongodb://127.0.0.1/');
 
 $client->getManager()->addSubscriber(new CommandLogger());
 
@@ -79,5 +79,6 @@ public function commandFailed(CommandFailedEvent $event): void
 $cursor = $collection->find([], ['batchSize' => 2]);
 
 foreach ($cursor as $document) {
+    assert(is_object($document));
     printf("%s\n", toJSON($document));
 }