Skip to content

Commit 510f812

Browse files
authored
PHPLIB-1243: Renamed add_logger() and remove_logger() functions (#1177)
This renames the camelCase names introduced in 1acfab0 to snake_case, which is consistent with other functions.
1 parent 28bcd68 commit 510f812

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/functions.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
* Calling this method again with a logger that has already been added will have
5454
* no effect.
5555
*/
56-
function addLogger(LoggerInterface $logger): void
56+
function add_logger(LoggerInterface $logger): void
5757
{
5858
PsrLogAdapter::addLogger($logger);
5959
}
@@ -64,7 +64,7 @@ function addLogger(LoggerInterface $logger): void
6464
* Calling this method with a logger that has not been added will have no
6565
* effect.
6666
*/
67-
function removeLogger(LoggerInterface $logger): void
67+
function remove_logger(LoggerInterface $logger): void
6868
{
6969
PsrLogAdapter::removeLogger($logger);
7070
}

tests/LogNonGenuineHostTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
use Psr\Log\LoggerInterface;
99

1010
use function func_get_args;
11-
use function MongoDB\addLogger;
12-
use function MongoDB\removeLogger;
11+
use function MongoDB\add_logger;
12+
use function MongoDB\remove_logger;
1313

1414
/** @see https://jira.mongodb.org/browse/DRIVERS-2583 */
1515
class LogNonGenuineHostTest extends TestCase
@@ -20,12 +20,12 @@ public function setUp(): void
2020
{
2121
$this->logger = $this->createTestPsrLogger();
2222

23-
addLogger($this->logger);
23+
add_logger($this->logger);
2424
}
2525

2626
public function tearDown(): void
2727
{
28-
removeLogger($this->logger);
28+
remove_logger($this->logger);
2929
}
3030

3131
/** @dataProvider provideCosmosUris */

tests/PsrLogAdapterTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
use Psr\Log\LogLevel;
1212

1313
use function func_get_args;
14-
use function MongoDB\addLogger;
14+
use function MongoDB\add_logger;
1515
use function MongoDB\Driver\Monitoring\mongoc_log;
16-
use function MongoDB\removeLogger;
16+
use function MongoDB\remove_logger;
1717
use function sprintf;
1818

1919
class PsrLogAdapterTest extends BaseTestCase
@@ -39,12 +39,12 @@ public function testAddAndRemoveLoggerFunctions(): void
3939
mongoc_log(LogSubscriber::LEVEL_INFO, 'domain1', 'info1');
4040
PsrLogAdapter::writeLog(PsrLogAdapter::INFO, 'domain2', 'info2');
4141

42-
addLogger($logger);
42+
add_logger($logger);
4343

4444
mongoc_log(LogSubscriber::LEVEL_INFO, 'domain3', 'info3');
4545
PsrLogAdapter::writeLog(PsrLogAdapter::INFO, 'domain4', 'info4');
4646

47-
removeLogger($logger);
47+
remove_logger($logger);
4848

4949
mongoc_log(LogSubscriber::LEVEL_INFO, 'domain5', 'info5');
5050
PsrLogAdapter::writeLog(PsrLogAdapter::INFO, 'domain6', 'info6');

0 commit comments

Comments
 (0)