Only support string offsets for LazyBSONDocument

Author: alcaeus

src/Model/LazyBSONDocument.php

@@ -33,6 +33,7 @@
 use function get_object_vars;
 use function is_array;
 use function is_object;
+use function is_string;
 use function MongoDB\recursive_copy;
 use function sprintf;
 use function trigger_error;
@@ -183,7 +184,11 @@ function ($value, string $key) use (&$seen) {
     /** @param mixed $offset */
     public function offsetExists($offset): bool
     {
-        return $this->__isset((string) $offset);
+        if (! is_string($offset)) {
+            return false;
+        }
+
+        return $this->__isset($offset);
     }
 
     /**
@@ -193,7 +198,13 @@ public function offsetExists($offset): bool
     #[ReturnTypeWillChange]
     public function offsetGet($offset)
     {
-        return $this->__get((string) $offset);
+        if (! is_string($offset)) {
+            trigger_error(sprintf('Undefined offset: %s', (string) $offset), E_USER_WARNING);
+
+            return null;
+        }
+
+        return $this->__get($offset);
     }
 
     /**
@@ -202,13 +213,25 @@ public function offsetGet($offset)
      */
     public function offsetSet($offset, $value): void
     {
-        $this->__set((string) $offset, $value);
+        if (! is_string($offset)) {
+            trigger_error(sprintf('Unsupported offset: %s', (string) $offset), E_USER_WARNING);
+
+            return;
+        }
+
+        $this->__set($offset, $value);
     }
 
     /** @param mixed $offset */
     public function offsetUnset($offset): void
     {
-        $this->__unset((string) $offset);
+        if (! is_string($offset)) {
+            trigger_error(sprintf('Undefined offset: %s', (string) $offset), E_USER_WARNING);
+
+            return;
+        }
+
+        $this->__unset($offset);
     }
 
     private function readFromBson(string $key): void

tests/Model/LazyBSONDocumentTest.php

@@ -73,10 +73,8 @@ public function testConstructWithWrongType(): void
     }
 
     /** @dataProvider provideTestDocumentWithNativeArrays */
-    public function testConstructWithArrayUsesLiteralValues($value): void
+    public function testConstructWithArrayUsesLiteralValues($document): void
     {
-        $document = new LazyBSONDocument($value);
-
         $this->assertInstanceOf(stdClass::class, $document->document);
         $this->assertIsArray($document->hash);
         $this->assertIsArray($document->array);
@@ -143,6 +141,15 @@ public function testOffsetGetForMissingOffset(LazyBSONDocument $document): void
         $document['bar'];
     }
 
+    public function testOffsetGetWithInvalidOffset(): void
+    {
+        $document = new LazyBSONDocument(['foo' => 'bar']);
+
+        $this->expectWarning();
+        $this->expectWarningMessage('Undefined offset: 1');
+        $document[1];
+    }
+
     /** @dataProvider provideTestDocument */
     public function testGetDocument(LazyBSONDocument $document): void
     {
@@ -171,6 +178,13 @@ public function testOffsetExists(LazyBSONDocument $document): void
         $this->assertFalse(isset($document['bar']));
     }
 
+    public function testOffsetExistsWithInvalidOffset(): void
+    {
+        $document = new LazyBSONDocument(['foo' => 'bar']);
+
+        $this->assertFalse(isset($document[1]));
+    }
+
     /** @dataProvider provideTestDocument */
     public function testPropertySet(LazyBSONDocument $document): void
     {
@@ -195,6 +209,15 @@ public function testOffsetSet(LazyBSONDocument $document): void
         $this->assertSame('baz', $document['foo']);
     }
 
+    public function testOffsetSetWithInvalidOffset(): void
+    {
+        $document = new LazyBSONDocument(['foo' => 'bar']);
+
+        $this->expectWarning();
+        $this->expectWarningMessage('Unsupported offset: 1');
+        $document[1] = 'foo';
+    }
+
     /** @dataProvider provideTestDocument */
     public function testPropertyUnset(LazyBSONDocument $document): void
     {
@@ -229,6 +252,15 @@ public function testOffsetUnset(LazyBSONDocument $document): void
         $this->assertFalse(isset($document['document']));
     }
 
+    public function testOffsetUnsetWithInvalidOffset(): void
+    {
+        $document = new LazyBSONDocument(['foo' => 'bar']);
+
+        $this->expectWarning();
+        $this->expectWarningMessage('Undefined offset: 1');
+        unset($document[1]);
+    }
+
     /** @dataProvider provideTestDocument */
     public function testIterator(LazyBSONDocument $document): void
     {