Skip to content

Commit 68c5066

Browse files
authored
PHPLIB-1413: Use env instead of matrix for driver-version (#1261)
env vars are not available in jobs.<job_id>.strategy.matrix. Since the driver-version never changes for jobs, reference the common env var in step configs.
1 parent be19b52 commit 68c5066

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,35 +40,28 @@ jobs:
4040
- "8.3"
4141
mongodb-version:
4242
- "4.4"
43-
driver-version:
44-
- "${{ env.DRIVER_VERSION }}"
4543
topology:
4644
- "server"
4745
include:
4846
- os: "ubuntu-20.04"
4947
php-version: "8.0"
5048
mongodb-version: "6.0"
51-
driver-version: "${{ env.DRIVER_VERSION }}"
5249
topology: "replica_set"
5350
- os: "ubuntu-20.04"
5451
php-version: "8.0"
5552
mongodb-version: "6.0"
56-
driver-version: "${{ env.DRIVER_VERSION }}"
5753
topology: "sharded_cluster"
5854
- os: "ubuntu-20.04"
5955
php-version: "8.0"
6056
mongodb-version: "5.0"
61-
driver-version: "${{ env.DRIVER_VERSION }}"
6257
topology: "server"
6358
- os: "ubuntu-20.04"
6459
php-version: "8.0"
6560
mongodb-version: "4.4"
66-
driver-version: "${{ env.DRIVER_VERSION }}"
6761
topology: "replica_set"
6862
- os: "ubuntu-20.04"
6963
php-version: "8.0"
7064
mongodb-version: "4.4"
71-
driver-version: "${{ env.DRIVER_VERSION }}"
7265
topology: "sharded_cluster"
7366

7467
steps:
@@ -88,7 +81,7 @@ jobs:
8881
uses: shivammathur/cache-extensions@v1
8982
with:
9083
php-version: ${{ matrix.php-version }}
91-
extensions: "mongodb-${{ matrix.driver-version }}"
84+
extensions: "mongodb-${{ env.DRIVER_VERSION }}"
9285
key: "extcache-v1"
9386

9487
- name: Cache extensions
@@ -103,7 +96,7 @@ jobs:
10396
with:
10497
php-version: "${{ matrix.php-version }}"
10598
tools: "pecl"
106-
extensions: "mongodb-${{ matrix.driver-version }}"
99+
extensions: "mongodb-${{ env.DRIVER_VERSION }}"
107100
coverage: "none"
108101
ini-values: "zend.assertions=1"
109102

0 commit comments

Comments
 (0)