PHPLIB-1001: Support "number" alias for legacy $$type operator

Also add a default case to raise an exception for unsupported types, which were previously ignored.

Author: jmikola

tests/SpecTests/DocumentsMatchConstraint.php

@@ -4,6 +4,7 @@
 
 use ArrayObject;
 use InvalidArgumentException;
+use LogicException;
 use MongoDB\BSON\BinaryInterface;
 use MongoDB\BSON\DBPointer;
 use MongoDB\BSON\Decimal128;
@@ -243,6 +244,19 @@ private function assertBSONType(string $expectedType, $actualValue): void
                 (new IsInstanceOf(MaxKey::class))->evaluate($actualValue);
 
                 return;
+
+            case 'number':
+                LogicalOr::fromConstraints(
+                    new IsType('int'),
+                    new IsInstanceOf(Int64::class),
+                    new IsType('float'),
+                    new IsInstanceOf(Decimal128::class)
+                )->evaluate($actualValue);
+
+                return;
+
+            default:
+                throw new LogicException('Unsupported type: ' . $expectedType);
         }
     }
 

tests/SpecTests/DocumentsMatchConstraintTest.php

@@ -112,6 +112,11 @@ public function provideBSONTypes()
             'decimal' => ['decimal', new Decimal128('18446744073709551616')],
             'minKey' => ['minKey', new MinKey()],
             'maxKey' => ['maxKey', new MaxKey()],
+            'number(double)' => ['number', 1.4],
+            'number(decimal)' => ['number', new Decimal128('18446744073709551616')],
+            'number(int)' => ['number', 1],
+            'number(int64)' => ['number', $int64],
+            'number(long)' => ['number', $long],
         ];
     }