Skip to content

Commit 8f7d7f8

Browse files
committed
PHPLIB-532: Fix result expectation assertions for retryable writes
1 parent c1dc92c commit 8f7d7f8

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

tests/SpecTests/Context.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,6 @@ public static function fromRetryableWrites(stdClass $test, $databaseName, $colle
185185

186186
$clientOptions = isset($test->clientOptions) ? (array) $test->clientOptions : [];
187187

188-
// TODO: Remove this once retryWrites=true by default (see: PHPC-1324)
189-
$clientOptions['retryWrites'] = true;
190-
191188
if (isset($test->outcome->collection->name)) {
192189
$o->outcomeCollectionName = $test->outcome->collection->name;
193190
}

tests/SpecTests/ResultExpectation.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public static function fromRetryableReads(stdClass $operation, $defaultAssertion
126126

127127
public static function fromRetryableWrites(stdClass $outcome, $defaultAssertionType)
128128
{
129-
if (property_exists($outcome, 'result')) {
129+
if (property_exists($outcome, 'result') && ! self::isErrorResult($outcome->result)) {
130130
$assertionType = $outcome->result === null ? self::ASSERT_NULL : $defaultAssertionType;
131131
$expectedValue = $outcome->result;
132132
} else {

0 commit comments

Comments
 (0)