Use $manager->selectServer() default primary

Author: GromNaN

rector.php

@@ -10,16 +10,20 @@
         __DIR__ . '/src',
         __DIR__ . '/tests',
         __DIR__ . '/tools',
-        __FILE__,
     ]);
 
-    // ReadPreference::RP_* constants are deprecated in favor of the string constants
+    /**
+     * ReadPreference::RP_* constants are deprecated in favor of the string constants
+     *
+     * @see https://jira.mongodb.org/browse/PHPC-1489
+     * @see https://jira.mongodb.org/browse/PHPC-1021
+     */
     $rectorConfig->ruleWithConfiguration(RenameClassConstFetchRector::class, [
-        new RenameClassConstFetch('MongoDB\Driver\ReadPreference', 'RP_PRIMARY', 'PRIMARY'),
-        new RenameClassConstFetch('MongoDB\Driver\ReadPreference', 'RP_PRIMARY_PREFERRED', 'PRIMARY_PREFERRED'),
-        new RenameClassConstFetch('MongoDB\Driver\ReadPreference', 'RP_SECONDARY', 'SECONDARY'),
-        new RenameClassConstFetch('MongoDB\Driver\ReadPreference', 'RP_SECONDARY_PREFERRED', 'SECONDARY_PREFERRED'),
-        new RenameClassConstFetch('MongoDB\Driver\ReadPreference', 'RP_NEAREST', 'NEAREST'),
+        new RenameClassConstFetch(MongoDB\Driver\ReadPreference::class, 'RP_PRIMARY', 'PRIMARY'),
+        new RenameClassConstFetch(MongoDB\Driver\ReadPreference::class, 'RP_PRIMARY_PREFERRED', 'PRIMARY_PREFERRED'),
+        new RenameClassConstFetch(MongoDB\Driver\ReadPreference::class, 'RP_SECONDARY', 'SECONDARY'),
+        new RenameClassConstFetch(MongoDB\Driver\ReadPreference::class, 'RP_SECONDARY_PREFERRED', 'SECONDARY_PREFERRED'),
+        new RenameClassConstFetch(MongoDB\Driver\ReadPreference::class, 'RP_NEAREST', 'NEAREST'),
     ]);
 
     // define sets of rules

tests/FunctionalTestCase.php

@@ -305,7 +305,7 @@ protected function getFeatureCompatibilityVersion(?ReadPreference $readPreferenc
 
     protected function getPrimaryServer()
     {
-        return $this->manager->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+        return $this->manager->selectServer();
     }
 
     protected function getServerVersion(?ReadPreference $readPreference = null)
@@ -611,7 +611,7 @@ private static function getUriWithoutMultipleMongoses(): string
         }
 
         $manager = static::createTestManager($uri);
-        if ($manager->selectServer(new ReadPreference(ReadPreference::PRIMARY))->getType() !== Server::TYPE_MONGOS) {
+        if ($manager->selectServer()->getType() !== Server::TYPE_MONGOS) {
             return $uri;
         }
 

tests/Operation/FindAndModifyFunctionalTest.php

@@ -6,7 +6,6 @@
 use MongoDB\BSON\PackedArray;
 use MongoDB\Driver\BulkWrite;
 use MongoDB\Driver\Exception\CommandException;
-use MongoDB\Driver\ReadPreference;
 use MongoDB\Driver\WriteConcern;
 use MongoDB\Exception\UnsupportedException;
 use MongoDB\Model\BSONArray;
@@ -115,7 +114,7 @@ public function provideUpdatePipelines(): array
     public function testManagerReadConcernIsOmitted(): void
     {
         $manager = static::createTestManager(null, ['readConcernLevel' => 'majority']);
-        $server = $manager->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+        $server = $manager->selectServer();
 
         (new CommandObserver())->observe(
             function () use ($server): void {

tests/Operation/WatchFunctionalTest.php

@@ -165,7 +165,7 @@ public function testNextResumesAfterConnectionException(): void
          * a socket timeout that is less than the change stream's maxAwaitTimeMS
          * option. */
         $manager = static::createTestManager(null, ['socketTimeoutMS' => 50]);
-        $primaryServer = $manager->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+        $primaryServer = $manager->selectServer();
 
         $operation = new Watch($manager, $this->getDatabaseName(), $this->getCollectionName(), [], $this->defaultOptions);
         $changeStream = $operation->execute($primaryServer);

tests/SpecTests/PrimaryStepDownSpecTest.php

@@ -208,7 +208,7 @@ public function testGetMoreIteration(): void
         $totalConnectionsCreated = $this->getTotalConnectionsCreated();
 
         // Send a {replSetStepDown: 5, force: true} command to the current primary and verify that the command succeeded
-        $primary = $this->client->getManager()->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+        $primary = $this->client->getManager()->selectServer();
 
         $success = false;
         $attempts = 0;
@@ -267,7 +267,7 @@ private function dropAndRecreateCollection(): void
 
     private function getTotalConnectionsCreated(?Server $server = null)
     {
-        $server = $server ?: $this->client->getManager()->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+        $server = $server ?: $this->client->getManager()->selectServer();
 
         $cursor = $server->executeCommand(
             $this->getDatabaseName(),
@@ -292,7 +292,7 @@ private function waitForPrimaryReelection(): void
 
             return;
         } catch (DriverException $e) {
-            $this->client->getManager()->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+            $this->client->getManager()->selectServer();
 
             return;
         }

tests/SpecTests/TransactionsSpecTest.php

@@ -6,7 +6,6 @@
 use MongoDB\BSON\Timestamp;
 use MongoDB\Driver\Command;
 use MongoDB\Driver\Exception\ServerException;
-use MongoDB\Driver\ReadPreference;
 use MongoDB\Driver\Server;
 use stdClass;
 
@@ -320,7 +319,7 @@ private static function killAllSessions(): void
         }
 
         $manager = static::createTestManager();
-        $primary = $manager->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+        $primary = $manager->selectServer();
 
         $servers = $primary->getType() === Server::TYPE_MONGOS
             ? $manager->getServers()

tests/UnifiedSpecTests/UnifiedTestRunner.php

@@ -4,7 +4,6 @@
 
 use MongoDB\Collection;
 use MongoDB\Driver\Exception\ServerException;
-use MongoDB\Driver\ReadPreference;
 use MongoDB\Driver\Server;
 use MongoDB\Model\BSONArray;
 use MongoDB\Operation\DatabaseCommand;
@@ -279,7 +278,7 @@ private function getPrimaryServer(): Server
     {
         $manager = $this->internalClient->getManager();
 
-        return $manager->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+        return $manager->selectServer();
     }
 
     private function getServerVersion(): string
@@ -438,7 +437,7 @@ private function killAllSessions(): void
         }
 
         $manager = $this->internalClient->getManager();
-        $primary = $manager->selectServer(new ReadPreference(ReadPreference::PRIMARY));
+        $primary = $manager->selectServer();
         $servers = $primary->getType() === Server::TYPE_MONGOS ? $manager->getServers() : [$primary];
 
         foreach ($servers as $server) {