Support new serverParameters runOnRequirement in unified test runner

Author: alcaeus

tests/FunctionalTestCase.php

@@ -267,6 +267,19 @@ protected function getPrimaryServer()
         return $this->manager->selectServer(new ReadPreference(ReadPreference::RP_PRIMARY));
     }
 
+    protected function getServerParameters()
+    {
+        $cursor = $this->manager->executeCommand(
+            'admin',
+            new Command(['getParameter' => '*']),
+            new ReadPreference(ReadPreference::RP_PRIMARY)
+        );
+
+        $cursor->rewind();
+
+        return $cursor->current();
+    }
+
     protected function getServerVersion(ReadPreference $readPreference = null)
     {
         $cursor = $this->manager->executeCommand(

tests/UnifiedSpecTests/RunOnRequirement.php

@@ -2,10 +2,12 @@
 
 namespace MongoDB\Tests\UnifiedSpecTests;
 
+use MongoDB\Tests\UnifiedSpecTests\Constraint\Matches;
 use stdClass;
 use function in_array;
 use function PHPUnit\Framework\assertContainsOnly;
 use function PHPUnit\Framework\assertIsArray;
+use function PHPUnit\Framework\assertIsObject;
 use function PHPUnit\Framework\assertIsString;
 use function PHPUnit\Framework\assertMatchesRegularExpression;
 use function version_compare;
@@ -28,6 +30,9 @@ class RunOnRequirement
     /** @var array */
     private $topologies;
 
+    /** @var stdClass */
+    private $serverParameters;
+
     public function __construct(stdClass $o)
     {
         if (isset($o->minServerVersion)) {
@@ -47,9 +52,14 @@ public function __construct(stdClass $o)
             assertContainsOnly('string', $o->topologies);
             $this->topologies = $o->topologies;
         }
+
+        if (isset($o->serverParameters)) {
+            assertIsObject($o->serverParameters);
+            $this->serverParameters = $o->serverParameters;
+        }
     }
 
-    public function isSatisfied(string $serverVersion, string $topology) : bool
+    public function isSatisfied(string $serverVersion, string $topology, stdClass $serverParameters) : bool
     {
         if (isset($this->minServerVersion) && version_compare($serverVersion, $this->minServerVersion, '<')) {
             return false;
@@ -73,6 +83,13 @@ public function isSatisfied(string $serverVersion, string $topology) : bool
             return false;
         }
 
+        if (isset($this->serverParameters)) {
+            $constraint = new Matches($this->serverParameters, null, true, false);
+            if (! $constraint->evaluate($serverParameters, '', true)) {
+                return false;
+            }
+        }
+
         return true;
     }
 }

tests/UnifiedSpecTests/UnifiedSpecTest.php

@@ -33,7 +33,7 @@ class UnifiedSpecTest extends FunctionalTestCase
     const SERVER_ERROR_INTERRUPTED = 11601;
 
     const MIN_SCHEMA_VERSION = '1.0';
-    const MAX_SCHEMA_VERSION = '1.1';
+    const MAX_SCHEMA_VERSION = '1.2';
 
     const TOPOLOGY_SINGLE = 'single';
     const TOPOLOGY_REPLICASET = 'replicaset';
@@ -252,17 +252,35 @@ private function checkRunOnRequirements(array $runOnRequirements)
 
         $serverVersion = $this->getCachedServerVersion();
         $topology = $this->getCachedTopology();
+        $serverParameters = $this->getCachedServerParameters();
 
         foreach ($runOnRequirements as $o) {
             $runOnRequirement = new RunOnRequirement($o);
-            if ($runOnRequirement->isSatisfied($serverVersion, $topology)) {
+            if ($runOnRequirement->isSatisfied($serverVersion, $topology, $serverParameters)) {
                 return;
             }
         }
 
+        // @todo Add server parameter requirements?
         $this->markTestSkipped(sprintf('Server version "%s" and topology "%s" do not meet test requirements', $serverVersion, $topology));
     }
 
+    /**
+     * Return the server parameters (cached for subsequent calls).
+     */
+    private function getCachedServerParameters()
+    {
+        static $cachedServerParameters;
+
+        if (isset($cachedServerParameters)) {
+            return $cachedServerParameters;
+        }
+
+        $cachedServerParameters = $this->getServerParameters();
+
+        return $cachedServerParameters;
+    }
+
     /**
      * Return the server version (cached for subsequent calls).
      *