PHPLIB-360: Make ChangeStream::CURSOR_NOT_FOUND private

Author: alcaeus

UPGRADE-2.0.md

@@ -3,6 +3,7 @@ UPGRADE FROM 1.x to 2.0
 
  * Classes in the namespace `MongoDB\Operation\` are `final`.
  * All methods in interfaces and classes now define a return type.
+ * The `MongoDB\ChangeStream::CURSOR_NOT_FOUND` constant is now private.
 
 GridFS
 ------

psalm-baseline.xml

@@ -179,11 +179,6 @@
             count($queriesOrArrayOfQueries[0]) > 0]]></code>
     </RedundantConditionGivenDocblockType>
   </file>
-  <file src="src/ChangeStream.php">
-    <DeprecatedConstant>
-      <code><![CDATA[self::CURSOR_NOT_FOUND]]></code>
-    </DeprecatedConstant>
-  </file>
   <file src="src/Client.php">
     <DeprecatedInterface>
       <code><![CDATA[DatabaseInfoIterator]]></code>

src/ChangeStream.php

@@ -43,11 +43,7 @@
  */
 class ChangeStream implements Iterator
 {
-    /**
-     * @deprecated 1.4
-     * @todo make this constant private in 2.0 (see: PHPLIB-360)
-     */
-    public const CURSOR_NOT_FOUND = 43;
+    private const CURSOR_NOT_FOUND = 43;
 
     private const RESUMABLE_ERROR_CODES = [
         6, // HostUnreachable