Skip to content

Commit ee0b453

Browse files
committed
Merge pull request #659
2 parents a42e347 + 944e729 commit ee0b453

File tree

4 files changed

+147
-70
lines changed

4 files changed

+147
-70
lines changed

mongo-orchestration/sharded_clusters/cluster_replset.json

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@
5050
"journal": true,
5151
"logappend": true,
5252
"port": 4400,
53-
"bind_ip_all": true
53+
"bind_ip_all": true,
54+
"setParameter": {
55+
"periodicNoopIntervalSecs": 1,
56+
"writePeriodicNoops": true
57+
}
5458
} },
5559
{ "procParams": {
5660
"dbpath": "/tmp/SHARDED-RS/SHARD1/4401",
@@ -59,7 +63,11 @@
5963
"journal": true,
6064
"logappend": true,
6165
"port": 4401,
62-
"bind_ip_all": true
66+
"bind_ip_all": true,
67+
"setParameter": {
68+
"periodicNoopIntervalSecs": 1,
69+
"writePeriodicNoops": true
70+
}
6371
} }
6472
]
6573
}
@@ -76,7 +84,11 @@
7684
"journal": true,
7785
"logappend": true,
7886
"port": 4410,
79-
"bind_ip_all": true
87+
"bind_ip_all": true,
88+
"setParameter": {
89+
"periodicNoopIntervalSecs": 1,
90+
"writePeriodicNoops": true
91+
}
8092
} },
8193
{ "procParams": {
8294
"dbpath": "/tmp/SHARDED-RS/SHARD2/4411",
@@ -85,7 +97,11 @@
8597
"journal": true,
8698
"logappend": true,
8799
"port": 4411,
88-
"bind_ip_all": true
100+
"bind_ip_all": true,
101+
"setParameter": {
102+
"periodicNoopIntervalSecs": 1,
103+
"writePeriodicNoops": true
104+
}
89105
} }
90106
]
91107
}

tests/DocumentationExamplesTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -935,6 +935,10 @@ public function testChangeStreamExample_1_4()
935935
{
936936
$this->skipIfChangeStreamIsNotSupported();
937937

938+
if ($this->isShardedCluster()) {
939+
$this->markTestSkipped('Test does not apply on sharded clusters: need more than a single getMore call on the change stream.');
940+
}
941+
938942
$db = new Database($this->manager, $this->getDatabaseName());
939943
$db->dropCollection('inventory');
940944
$db->createCollection('inventory');

tests/FunctionalTestCase.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -336,9 +336,6 @@ protected function skipIfChangeStreamIsNotSupported()
336336
if (! $this->isShardedClusterUsingReplicasets()) {
337337
$this->markTestSkipped('$changeStream is only supported with replicasets');
338338
}
339-
340-
// Temporarily skip tests because of an issue with change streams in the driver
341-
$this->markTestSkipped('$changeStreams currently don\'t on replica sets');
342339
break;
343340

344341
case Server::TYPE_RS_PRIMARY:

0 commit comments

Comments
 (0)