PHPLIB-1116: Add tests for runCommand spec (#1066)

Additional test runner changes were required to support runCommand spec tests.

Synced with mongodb/specifications@d697477

Author: jmikola

tests/UnifiedSpecTests/Operation.php

@@ -683,10 +683,16 @@ function (CollectionInfo $info) {
                 assertArrayHasKey('command', $args);
                 assertInstanceOf(stdClass::class, $args['command']);
 
-                return $database->command(
-                    $args['command'],
-                    array_diff_key($args, ['command' => 1])
-                )->toArray()[0];
+                // Note: commandName is not used by PHP
+                $options = array_diff_key($args, ['command' => 1, 'commandName' => 1]);
+
+                /* runCommand spec tests may execute commands that return a
+                 * cursor (e.g. aggregate). PHPC creates a cursor automatically
+                 * so cannot return the original command result. Existing spec
+                 * tests do not evaluate the result, so we can return null here.
+                 * If that changes down the line, we can use command monitoring
+                 * to capture and return the command result. */
+                return $database->command($args['command'], $options)->toArray()[0] ?? null;
 
             default:
                 Assert::fail('Unsupported database operation: ' . $this->name);

tests/UnifiedSpecTests/UnifiedSpecTest.php

@@ -168,6 +168,17 @@ public function provideLoadBalancers()
         return $this->provideTests(__DIR__ . '/load-balancers/*.json');
     }
 
+    /** @dataProvider provideRunCommandTests */
+    public function testRunCommand(UnifiedTestCase $test): void
+    {
+        self::$runner->run($test);
+    }
+
+    public function provideRunCommandTests()
+    {
+        return $this->provideTests(__DIR__ . '/run-command/*.json');
+    }
+
     /** @dataProvider provideSessionsTests */
     public function testSessions(UnifiedTestCase $test): void
     {

tests/UnifiedSpecTests/Util.php

@@ -80,7 +80,7 @@ final class Util
             'listCollections' => ['authorizedCollections', 'filter', 'maxTimeMS', 'session'],
             'modifyCollection' => ['collection', 'changeStreamPreAndPostImages', 'index', 'validator'],
             // Note: commandName is not used by PHP
-            'runCommand' => ['command', 'session', 'commandName'],
+            'runCommand' => ['command', 'commandName', 'readPreference', 'session'],
         ],
         Collection::class => [
             'aggregate' => ['pipeline', 'session', 'useCursor', 'allowDiskUse', 'batchSize', 'bypassDocumentValidation', 'collation', 'comment', 'explain', 'hint', 'let', 'maxAwaitTimeMS', 'maxTimeMS'],