Skip to content

PHPLIB-1247 Don't drop the database in ExamplesTest #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2023
Merged

PHPLIB-1247 Don't drop the database in ExamplesTest #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/atlas-search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
['name' => 'default'],
);

// Wait for the index to be ready.
// Wait for the index to be queryable.
wait(function () use ($collection) {
echo '.';
foreach ($collection->listSearchIndexes() as $index) {
Expand Down
2 changes: 0 additions & 2 deletions tests/ExamplesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ public function setUp(): void
if ($this->isApiVersionRequired()) {
$this->markTestSkipped('Examples are not tested when the server requires specifying an API version.');
}

self::createTestClient()->dropDatabase('test');
}

/** @dataProvider provideExamples */
Expand Down