Skip to content

Commit 5e00979

Browse files
committed
decentralize skipping code
1 parent fb05c59 commit 5e00979

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

test/unified_format.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -549,13 +549,6 @@ def setUpClass(cls):
549549
if cls.TEST_SPEC['description'].find('retryable-writes') != -1:
550550
raise unittest.SkipTest(
551551
"MMAPv1 does not support retryWrites=True")
552-
if cls.TEST_SPEC['description'].find('change-streams') != -1:
553-
raise unittest.SkipTest(
554-
"MMAPv1 does not support change streams")
555-
if cls.TEST_SPEC['description'].find(
556-
'transactions-convenient-api') != -1:
557-
raise unittest.SkipTest(
558-
"MMAPv1 does not support document-level locking")
559552

560553
@classmethod
561554
def tearDownClass(cls):
@@ -643,6 +636,8 @@ def __raise_if_unsupported(self, opname, target, *target_types):
643636
'of type %s' % (opname, type(target)))
644637

645638
def __entityOperation_createChangeStream(self, target, *args, **kwargs):
639+
if client_context.storage_engine == 'mmapv1':
640+
self.skipTest("MMAPv1 does not support change streams")
646641
self.__raise_if_unsupported(
647642
'createChangeStream', target, MongoClient, Database, Collection)
648643
return target.watch(*args, **kwargs)
@@ -702,9 +697,17 @@ def _collectionOperation_insertOne(self, target, *args, **kwargs):
702697
return {'insertedId': result.inserted_id}
703698

704699
def _sessionOperation_withTransaction(self, target, *args, **kwargs):
700+
if client_context.storage_engine == 'mmapv1':
701+
self.skipTest('MMAPv1 does not support document-level locking')
705702
self.__raise_if_unsupported('withTransaction', target, ClientSession)
706703
return target.with_transaction(*args, **kwargs)
707704

705+
def _sessionOperation_startTransaction(self, target, *args, **kwargs):
706+
if client_context.storage_engine == 'mmapv1':
707+
self.skipTest('MMAPv1 does not support document-level locking')
708+
self.__raise_if_unsupported('startTransaction', target, ClientSession)
709+
return target.start_transaction(*args, **kwargs)
710+
708711
def _changeStreamOperation_iterateUntilDocumentOrError(self, target,
709712
*args, **kwargs):
710713
self.__raise_if_unsupported(

0 commit comments

Comments
 (0)