Skip to content

Commit 8ed2d87

Browse files
committed
modified assertRaises test to work with async pt2
1 parent d7ec329 commit 8ed2d87

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

test/asynchronous/test_auth.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,10 @@ def auth_string(user, password):
332332
bad_user = AsyncMongoClient(auth_string("not-user", SASL_PASS))
333333
bad_pwd = AsyncMongoClient(auth_string(SASL_USER, "not-pwd"))
334334
# OperationFailure raised upon connecting.
335-
self.assertRaises(OperationFailure, bad_user.admin.command, "ping")
336-
self.assertRaises(OperationFailure, bad_pwd.admin.command, "ping")
335+
with self.assertRaises(OperationFailure):
336+
await bad_user.admin.command("ping")
337+
with self.assertRaises(OperationFailure):
338+
await bad_pwd.admin.command("ping")
337339

338340

339341
class TestSCRAMSHA1(AsyncIntegrationTest):
@@ -654,15 +656,17 @@ async def test_uri_options(self):
654656
async_client_context.replica_set_name,
655657
)
656658
client = await async_single_client_noauth(uri)
657-
self.assertRaises(OperationFailure, client.admin.command, "dbstats")
659+
with self.assertRaises(OperationFailure):
660+
await client.admin.command("dbstats")
658661
self.assertTrue(await client.pymongo_test.command("dbstats"))
659662
db = client.get_database("pymongo_test", read_preference=ReadPreference.SECONDARY)
660663
self.assertTrue(await db.command("dbstats"))
661664

662665
# Test authSource
663666
uri = "mongodb://user:pass@%s:%d/pymongo_test2?authSource=pymongo_test" % (host, port)
664667
client = await async_rs_or_single_client_noauth(uri)
665-
self.assertRaises(OperationFailure, client.pymongo_test2.command, "dbstats")
668+
with self.assertRaises(OperationFailure):
669+
await client.pymongo_test2.command("dbstats")
666670
self.assertTrue(await client.pymongo_test.command("dbstats"))
667671

668672
if async_client_context.is_rs:
@@ -671,7 +675,8 @@ async def test_uri_options(self):
671675
"%s;authSource=pymongo_test" % (host, port, async_client_context.replica_set_name)
672676
)
673677
client = await async_single_client_noauth(uri)
674-
self.assertRaises(OperationFailure, client.pymongo_test2.command, "dbstats")
678+
with self.assertRaises(OperationFailure):
679+
await client.pymongo_test2.command("dbstats")
675680
self.assertTrue(await client.pymongo_test.command("dbstats"))
676681
db = client.get_database("pymongo_test", read_preference=ReadPreference.SECONDARY)
677682
self.assertTrue(await db.command("dbstats"))

test/test_auth.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,10 @@ def auth_string(user, password):
332332
bad_user = MongoClient(auth_string("not-user", SASL_PASS))
333333
bad_pwd = MongoClient(auth_string(SASL_USER, "not-pwd"))
334334
# OperationFailure raised upon connecting.
335-
self.assertRaises(OperationFailure, bad_user.admin.command, "ping")
336-
self.assertRaises(OperationFailure, bad_pwd.admin.command, "ping")
335+
with self.assertRaises(OperationFailure):
336+
bad_user.admin.command("ping")
337+
with self.assertRaises(OperationFailure):
338+
bad_pwd.admin.command("ping")
337339

338340

339341
class TestSCRAMSHA1(IntegrationTest):
@@ -642,15 +644,17 @@ def test_uri_options(self):
642644
client_context.replica_set_name,
643645
)
644646
client = single_client_noauth(uri)
645-
self.assertRaises(OperationFailure, client.admin.command, "dbstats")
647+
with self.assertRaises(OperationFailure):
648+
client.admin.command("dbstats")
646649
self.assertTrue(client.pymongo_test.command("dbstats"))
647650
db = client.get_database("pymongo_test", read_preference=ReadPreference.SECONDARY)
648651
self.assertTrue(db.command("dbstats"))
649652

650653
# Test authSource
651654
uri = "mongodb://user:pass@%s:%d/pymongo_test2?authSource=pymongo_test" % (host, port)
652655
client = rs_or_single_client_noauth(uri)
653-
self.assertRaises(OperationFailure, client.pymongo_test2.command, "dbstats")
656+
with self.assertRaises(OperationFailure):
657+
client.pymongo_test2.command("dbstats")
654658
self.assertTrue(client.pymongo_test.command("dbstats"))
655659

656660
if client_context.is_rs:
@@ -659,7 +663,8 @@ def test_uri_options(self):
659663
"%s;authSource=pymongo_test" % (host, port, client_context.replica_set_name)
660664
)
661665
client = single_client_noauth(uri)
662-
self.assertRaises(OperationFailure, client.pymongo_test2.command, "dbstats")
666+
with self.assertRaises(OperationFailure):
667+
client.pymongo_test2.command("dbstats")
663668
self.assertTrue(client.pymongo_test.command("dbstats"))
664669
db = client.get_database("pymongo_test", read_preference=ReadPreference.SECONDARY)
665670
self.assertTrue(db.command("dbstats"))

0 commit comments

Comments
 (0)