PYTHON-3717 Speed up _type_marker check in BSON #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2023
|
Hi @thalassemia, thanks for working on this! We should be able to add this value to the module_state, and then clear it on teardown. See here for an example of interacting with the module state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In _cbsonmodule.c, the
_type_markerfunction usesPyObject_HasAttrString(object, "_type_marker")andPyObject_GetAttrString(object, "_type_marker"). In my workloads (highly nested documents with many large array fields), these functions become severe bottlenecks to performance, because they each create new Python string objects by callingPyUnicode_FromString("_type_marker")internally every time they run.This simple change improved my performance by more than double. One caveat is that this leaks the
TYPEMARKERSTRobject in the case that thecbsonmodule is unloaded.Also, correct me if I'm wrong, but I believe these lines are redundant because the function returns type at the end regardless.