PYTHON-2308 Test that we exclusively depend on existence of logicalSessionsTimeoutMinutes for sessions support #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssionsTimeoutMinutes for sessions support
ShaneHarvey
commented
Oct 6, 2020
test/test_session.py
Outdated
| @@ -863,7 +866,6 @@ def _test_reads(self, op, exception=None): | |||
| 'readConcern', {}).get('afterClusterTime') | |||
| self.assertEqual(operation_time, act) | |||
|
|
|||
| @client_context.require_no_standalone | |||
There was a problem hiding this comment.
I made these changes because this line was removed from the prose tests:
The test plan SHOULD be run against both replica set and sharded cluster
topologies. It MUST NOT be run against a standalone server.
mongodb/specifications@cdbc6ca#diff-042f65298ff835d62143081f7356a4ceL981
There was a problem hiding this comment.
Turns out we already run the session prose tests (TestSession) against standalone clusters. I reverted the changes I made here because they were for the TestCausalConsistency class which implements the Causal Consistency spec prose tests. The causal prose test plan still says to skip standalones so there's nothing to be done here.
prashantmital
approved these changes
Oct 8, 2020
prashantmital
suggested changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resyncs the session spec tests and updates the prose tests to ensure we comply with the updated spec.