Skip to content

PYTHON-1316 Remove Database.eval and database.SystemJS #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 12, 2021
Merged

PYTHON-1316 Remove Database.eval and database.SystemJS #542

merged 5 commits into from
Jan 12, 2021

Conversation

ShaneHarvey
Copy link
Member

Depends on #540.

behackett
behackett requested changes Jan 12, 2021
View reviewed changes
doc/migrate-to-pymongo4.rst Outdated

>>> result = database.eval('function (x) {return x;}', 3)

can be changed to this with MongoDB <= 4.0::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should say explicitly that there is no replacement for eval when using MongoDB 4.2+.

prashantmital
prashantmital reviewed Jan 12, 2021
View reviewed changes
Copy link
Contributor

@prashantmital prashantmital left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not count as a removed feature with no migration path for MongoDB 4.2+? Should we add a line or two addressing this to that section?

@ShaneHarvey
Copy link
Member Author

ShaneHarvey commented Jan 12, 2021 •
edited
Loading

Does this not count as a removed feature with no migration path for MongoDB 4.2+? Should we add a line or two addressing this to that section?

I didn't really think it was a good fit for that category because eval will not work on MongoDB 4.2+ even on PyMongo 3.x.

Edit: On second thought you have a good point. I moved the whole section to "Removed features with no migration path". Either way is fine with me.

prashantmital
prashantmital approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@prashantmital prashantmital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShaneHarvey ShaneHarvey merged commit b3c26a7 into mongodb:master Jan 12, 2021
@ShaneHarvey ShaneHarvey deleted the PYTHON-1316 branch January 12, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackett behackett behackett requested changes

@prashantmital prashantmital prashantmital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaneHarvey @behackett @prashantmital