Skip to content

PYTHON-2057 Make 'name' a required argument for DriverInfo class #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2021
Merged

PYTHON-2057 Make 'name' a required argument for DriverInfo class #718

merged 4 commits into from
Sep 8, 2021

Conversation

juliusgeo
Copy link
Contributor

@juliusgeo juliusgeo changed the title Python 2057: Make 'name' a required argument for DriverInfo class PYTHON 2057 Make 'name' a required argument for DriverInfo class Sep 2, 2021
@juliusgeo juliusgeo changed the title PYTHON 2057 Make 'name' a required argument for DriverInfo class PYTHON-2057 Make 'name' a required argument for DriverInfo class Sep 2, 2021
prashantmital
prashantmital approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@prashantmital prashantmital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please wait for Shane's approval before merging :).

ShaneHarvey
ShaneHarvey requested changes Sep 7, 2021
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog and the migrate-to-pymongo4 document to mention this breaking change?

ShaneHarvey
ShaneHarvey requested changes Sep 7, 2021
View reviewed changes
doc/migrate-to-pymongo4.rst

Name is a required argument for pymongo.driver_info.DriverInfo
..............................................................
``name`` is now a required argument for the :class:`pymongo.driver_info.DriverInfo` class.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be a blank line after the ....... header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@juliusgeo juliusgeo merged commit 88e86f6 into mongodb:master Sep 8, 2021
juliusgeo added a commit to juliusgeo/mongo-python-driver that referenced this pull request Oct 1, 2021
@juliusgeo
PYTHON-2057 Make 'name' a required argument for DriverInfo class (mon…
0b64a4f 
…godb#718)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@prashantmital prashantmital prashantmital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusgeo @ShaneHarvey @prashantmital