Skip to content

PYTHON-3028 $regex as a field name does not allow for non-string values #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

juliusgeo
Copy link
Contributor

No description provided.

@juliusgeo juliusgeo requested a review from ShaneHarvey December 3, 2021 23:39
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ready for review because there are no tests.

@juliusgeo
Copy link
Contributor Author

This is not ready for review because there are no tests.

Sorry about that, added tests.

Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice test!

@juliusgeo juliusgeo marked this pull request as ready for review December 6, 2021 21:13
@juliusgeo juliusgeo merged commit 70f7fe7 into mongodb:master Dec 6, 2021
ShaneHarvey pushed a commit that referenced this pull request Dec 7, 2021
ShaneHarvey pushed a commit that referenced this pull request Dec 7, 2021
ShaneHarvey pushed a commit that referenced this pull request Dec 7, 2021
juliusgeo added a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 5, 2022
juliusgeo added a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 6, 2022
juliusgeo added a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants